Skip to content

Tests for the #[export] macro#6691

Merged
andybalaam merged 2 commits into
mainfrom
andybalaam/test-export-macro
Jul 7, 2026
Merged

Tests for the #[export] macro#6691
andybalaam merged 2 commits into
mainfrom
andybalaam/test-export-macro

Conversation

@andybalaam

Copy link
Copy Markdown
Member

I thought there was a bug in the #[export] macro so I wrote some tests. It seems to be fine, but the tests are hopefully still useful.

  • This PR makes no API changes so needs no changelog entry
  • No AI was used to make this PR

@andybalaam andybalaam requested a review from a team as a code owner June 25, 2026 16:32
@andybalaam andybalaam requested review from stefanceriu and removed request for a team June 25, 2026 16:32
@andybalaam

Copy link
Copy Markdown
Member Author

@poljar is it OK for me to set tests = true in bindings/matrix-sdk-ffi-macros/Cargo.toml? (This PR does that, so I can run the tests.)

@poljar

poljar commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@poljar is it OK for me to set tests = true in bindings/matrix-sdk-ffi-macros/Cargo.toml? (This PR does that, so I can run the tests.)

I think you can also just remove that line, yes it's fine.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.94%. Comparing base (4c15c79) to head (cdc3d6b).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6691      +/-   ##
==========================================
+ Coverage   89.92%   89.94%   +0.01%     
==========================================
  Files         398      398              
  Lines      111154   111154              
  Branches   111154   111154              
==========================================
+ Hits        99952    99972      +20     
+ Misses       7403     7390      -13     
+ Partials     3799     3792       -7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 48.63%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 49 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation Restore session [memory store] 168.5 ms 113.4 ms +48.63%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing andybalaam/test-export-macro (cdc3d6b) with main (4c15c79)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (82585d7) during the generation of this report, so 4c15c79 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@andybalaam andybalaam enabled auto-merge (rebase) June 29, 2026 10:50
@andybalaam andybalaam disabled auto-merge June 29, 2026 10:50
@andybalaam andybalaam enabled auto-merge (rebase) June 29, 2026 10:51
@andybalaam andybalaam force-pushed the andybalaam/test-export-macro branch 2 times, most recently from 48b1235 to e138043 Compare June 30, 2026 10:52
@andybalaam andybalaam disabled auto-merge June 30, 2026 10:52
@stefanceriu stefanceriu removed their request for review July 3, 2026 11:13
@andybalaam andybalaam force-pushed the andybalaam/test-export-macro branch from e138043 to 2ab4801 Compare July 7, 2026 10:20
@andybalaam andybalaam force-pushed the andybalaam/test-export-macro branch from 2ab4801 to cdc3d6b Compare July 7, 2026 11:43
@andybalaam andybalaam enabled auto-merge (rebase) July 7, 2026 11:43
@andybalaam andybalaam merged commit 57d62a1 into main Jul 7, 2026
61 of 62 checks passed
@andybalaam andybalaam deleted the andybalaam/test-export-macro branch July 7, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants