Revert "refactor(ffi): Remove unused Session::homeserver_url value"

[jmartinesp]

This reverts commit 4eb3cc9.Reverts #5874

Turns out this didn't make the ClientBuilder safer but completely broke it when the server is not reachable and we try to restore a session. The complement crypto PR is: matrix-org/complement-crypto#217.

[Hywan]

I don't see how this value is used. Where is it used/read?

[jmartinesp]

We use it in the clients, to be able to save it locally to our own DB, which we will later read from and use this info to restore the client.

I thought we didn't need this anymore, but it seems like I completely misunderstood how this is used. The problem is now we need something that allows us to restore the server name and the HS url and not trigger a HS discovery request if we already had some server info.

However, I'm not sure how feasible this is at the moment since we don't have a way to check the StateStore before the parent Client is created if I'm not mistsaken. Maybe we could create an instance of it, use it just for this check, then drop it before creating the Client.

---

Well, that isn't possible because BaseStateStore is only present in the matrix-sdk-base crate...

[codspeed-hq]

CodSpeed Performance Report

Merging #5876 will not alter performance

_{Comparing revert-5874-refactor/safer-client-builder (3341e80) with main (1c22d0b)}

Summary

✅ 50 untouched