Skip to content

Upgrade bindings to Rust edition 2024#5308

Merged
poljar merged 3 commits into
mainfrom
jplatte/ffi-rust2024
Apr 7, 2026
Merged

Upgrade bindings to Rust edition 2024#5308
poljar merged 3 commits into
mainfrom
jplatte/ffi-rust2024

Conversation

@jplatte

@jplatte jplatte commented Jun 29, 2025

Copy link
Copy Markdown
Collaborator
  • No public API changes
  • No LLMs used

Signed-off-by: Jonas Platte

@jplatte

jplatte commented Jun 29, 2025

Copy link
Copy Markdown
Collaborator Author

Looks like this is blocked on #5189, which is in turn blocked on matrix-org/complement-crypto#197.

@poljar

poljar commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

This PR has bitrotten quite a bit, I think it should be unblocked now due to the various PRs being addressed.

Feel free to reopen if you get it rebased.

@poljar poljar closed this Dec 5, 2025
@jplatte jplatte reopened this Dec 9, 2025
@jplatte jplatte force-pushed the jplatte/ffi-rust2024 branch 2 times, most recently from 95e6b49 to 215f810 Compare December 9, 2025 09:45
@codspeed-hq

codspeed-hq Bot commented Dec 9, 2025

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing jplatte/ffi-rust2024 (ec0beea) with main (3539487)

Open in CodSpeed

@codecov

codecov Bot commented Dec 9, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.87%. Comparing base (3539487) to head (ec0beea).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5308      +/-   ##
==========================================
- Coverage   89.88%   89.87%   -0.02%     
==========================================
  Files         378      378              
  Lines      103437   103437              
  Branches   103437   103437              
==========================================
- Hits        92978    92967      -11     
- Misses       6890     6899       +9     
- Partials     3569     3571       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jplatte jplatte force-pushed the jplatte/ffi-rust2024 branch from 215f810 to 5e27361 Compare January 11, 2026 22:23
@jplatte jplatte force-pushed the jplatte/ffi-rust2024 branch 3 times, most recently from 3144a81 to 9c538e6 Compare April 1, 2026 19:03
@poljar

poljar commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

This passes CI now, is it ready to be undrafted?

@jplatte jplatte marked this pull request as ready for review April 2, 2026 14:21
@jplatte jplatte requested a review from a team as a code owner April 2, 2026 14:21
@jplatte jplatte requested review from bnjbvr and removed request for a team April 2, 2026 14:21
@poljar poljar requested review from poljar and removed request for bnjbvr April 7, 2026 08:28

@poljar poljar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, could you just get rid of the merge conflicts?

Sorry this wasn't merged before some other PRs which caused the conflicts.

@jplatte jplatte force-pushed the jplatte/ffi-rust2024 branch from 9c538e6 to ec0beea Compare April 7, 2026 10:24
@poljar poljar enabled auto-merge (rebase) April 7, 2026 10:28
@poljar

poljar commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Thanks again for the rebase. Marked for an auto-merge.

@poljar poljar merged commit 12cd1ef into main Apr 7, 2026
53 checks passed
@poljar poljar deleted the jplatte/ffi-rust2024 branch April 7, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants