Disable complement crypto tests temporarily#5188
Merged
Merged
Conversation
As per comment
t3chguy
requested changes
Feb 12, 2026
t3chguy
left a comment
t3chguy
left a comment
Member
There was a problem hiding this comment.
downstream-complement-crypto will just error with it commented out, needs & steps need updating too
t3chguy
reviewed
Feb 12, 2026
| steps: | ||
| - if: needs.complement-crypto.result != 'skipped' && needs.complement-crypto.result != 'success' | ||
| run: exit 1 | ||
| #downstream-complement-crypto: |
Member
There was a problem hiding this comment.
I think this task wants to stay otherwise you also need to update the branch protections, cleaner to just stub the task out
Member
Author
There was a problem hiding this comment.
oh, I already remove the branch protection but I can do that instead
t3chguy
approved these changes
Feb 12, 2026
Member
|
Can be reverted once matrix-org/complement-crypto#223 lands |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per comment
Checklist
public/exportedsymbols have accurate TSDoc documentation.