🐛 Hangup call with MXCallHangupReasonInviteTimeout reason when invite expires#1341
Open
ferologics wants to merge 2 commits into
Open
🐛 Hangup call with MXCallHangupReasonInviteTimeout reason when invite expires#1341ferologics wants to merge 2 commits into
ferologics wants to merge 2 commits into
Conversation
|
@stefanceriu I believe we can also merge this as it matches the matrix spec? |
ismailgulek
suggested changes
Jun 15, 2022
| } | ||
|
|
||
| // Send the notif that the call expired to the app | ||
| [self setState:MXCallStateInviteExpired reason:nil]; |
Contributor
There was a problem hiding this comment.
We need to keep this state change before sending hangup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iOS client MatrixSDK is using a 30 second timer that is initiated whenever a call invite is sent. Once it fires the state is set to ended, but only locally, and no
.callHangupwith inviteTimeout reason is sent. The PR corrects this to be in line with them.call.hangupevent specification:Signed-off-by: Frantisek Hetes f.hetes@gmail.com