Replace archived matrix-org/gomatrix dependency#466
Conversation
7f9fe51 to
6314c3e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 53.90% 53.91%
=======================================
Files 52 52
Lines 6025 6026 +1
=======================================
+ Hits 3248 3249 +1
Misses 2363 2363
Partials 414 414 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e02cf09 to
5fae1d7
Compare
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
5fae1d7 to
8029bac
Compare
|
Looks like this won't be as straightforward as I thought because apparently dendrite would require changes, too. |
kegsay
left a comment
There was a problem hiding this comment.
LGTM, though I suspect this is a breaking change as users of this library will type assert gomatrix errors.
|
Yeah. 😕 Not sure how to avoid that though? |
|
iirc, we tried to never break Dendrite but didn't really care about gmsl. |
| repository: "element-hq/dendrite" | ||
| # TODO: Switch back to element-hq/dendrite once | ||
| # https://github.com/element-hq/dendrite/pull/3708 is merged | ||
| repository: "Johennes/dendrite" | ||
| ref: "johannes/gomatrix" |
There was a problem hiding this comment.
This is for testing and demonstration purposes only and needs to be removed before merging.
|
I don't see a way to not break dendrite due to the type change. I've now downgraded mautrix/go to the same version used in dendrite and opened element-hq/dendrite#3708 to replace matrix-org/gomatrix in dendrite, too. |
This switches from https://github.com/matrix-org/gomatrix (which is archived) to https://github.com/mautrix/go.
Pull Request Checklist