Fix Rust breaking changes (removal of RoomListItem)#181
Conversation
|
I think the test is failing because the timeline created by
|
|
For what it's worth, it seems that I wonder if the
In some cases, it seems the Rust SDK doesn't emit timeline diff updates for all the events in the room. I think this may happen because the server marked a sliding sync as limited/gappy, so the SDK may have reset the timeline, resulting in a limited view over the timeline's events. It's not possible to tell if that happened, from looking at the current logs (and unfortunately I can't run this test locally, as I'm running into strange unmarshall errors, maybe related to using google-chrome at a different version than the one expected here). Some events appear as missing, but they should be present in the persistent storage. If a subsequent back-pagination happened they'd be immediately reloaded from the store, if they've been seen; or correctly reloaded from the network, if the server decided to return only a subset of the events for any reason. The above test Of course, I might be wrong here, and there might be a bug where the client is missing some events, but this sounds rather unlikely. I'm tempted to add a back-pagination there too, in case we're hitting this edge-case, but maybe we can see how this works out first, in general. |
Hywan
left a comment
There was a problem hiding this comment.
The code looks good. I'm okay with the way the timeline is cached and the place where it is computed.
Thanks!
Also a few unrelated goodies for generally helping with this repo maintenance.
Rust PR.