Skip to content

Limit MATLAB Test product installation check to decision, condition, and mcdc metric levels#98

Closed
mw-kapilg wants to merge 1 commit into
mainfrom
kapilg/update-product-requirement
Closed

Limit MATLAB Test product installation check to decision, condition, and mcdc metric levels#98
mw-kapilg wants to merge 1 commit into
mainfrom
kapilg/update-product-requirement

Conversation

@mw-kapilg

Copy link
Copy Markdown
Contributor

Summary

  • The MATLAB Test product installation check in CodeCoverageSummaryPluginService is now only performed for decision, condition, and mcdc metric levels.
  • For statement and function metric levels, coverage summary generation no longer requires the MATLAB Test product to be installed.
  • The license('test', 'matlab_test') check continues to apply for all metric levels.

@davidbuzinski davidbuzinski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definite improvement. There's still a puzzle to me because we default to mcdc so this won't be on by default in most cases, even if the user provides all of the other required information.

Also, there's still the problem that if the user requests a coverage report with any other format, this won't show up. It seems like in almost all real use-cases where the user provides enough info to collect coverage, this won't show up.

@mw-kapilg

Copy link
Copy Markdown
Contributor Author

Definite improvement. There's still a puzzle to me because we default to mcdc so this won't be on by default in most cases, even if the user provides all of the other required information.

Also, there's still the problem that if the user requests a coverage report with any other format, this won't show up. It seems like in almost all real use-cases where the user provides enough info to collect coverage, this won't show up.

For the first issue:
We can change the action's default to an empty string. On the MATLAB side, an empty value means "auto-detect" — if MATLAB Test is installed, use mcdc; otherwise, fall back to statement. If the user explicitly sets a level that requires MATLAB Test (decision/condition/mcdc) and it's not installed, we respect their choice and skip coverage generation entirely.

For the second issue, we don't have a better architecture to support it at the moment

@mw-kapilg

Copy link
Copy Markdown
Contributor Author

Closing this PR and will create a new one with proposed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants