Skip to content

Display author names throughout site, refactor to simpler author keys#122

Merged
oscarlevin merged 11 commits into
mainfrom
StevenClontz/20260522/fix-authors
May 22, 2026
Merged

Display author names throughout site, refactor to simpler author keys#122
oscarlevin merged 11 commits into
mainfrom
StevenClontz/20260522/fix-authors

Conversation

@StevenClontz
Copy link
Copy Markdown
Contributor

@StevenClontz StevenClontz commented May 22, 2026

Closes #119

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 22, 2026

Deploying mathtechorg-github-io with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2c36970
Status: ✅  Deploy successful!
Preview URL: https://f63688eb.mathtechorg-github-io.pages.dev
Branch Preview URL: https://stevenclontz-20260522-fix-au.mathtechorg-github-io.pages.dev

View logs

@oscarlevin
Copy link
Copy Markdown
Contributor

oscarlevin commented May 22, 2026

I beat you to it: #118

@StevenClontz
Copy link
Copy Markdown
Contributor Author

It was broken (-:

@oscarlevin
Copy link
Copy Markdown
Contributor

Broken how? The live site seems right.

The build previews weren't working because of a dumb encoding issue. But that's fixed.

@StevenClontz
Copy link
Copy Markdown
Contributor Author

It's possible I broke it fixing it a different way than you fixed it. 😅

But I do think this is a bit cleaner, always yielding author_key to the template. This PR also makes author keys obviously a key to something else (#119), and displays author names more clearly throughout the site.

@StevenClontz StevenClontz marked this pull request as ready for review May 22, 2026 19:30
@StevenClontz StevenClontz requested a review from oscarlevin May 22, 2026 19:30
@StevenClontz StevenClontz changed the title Fix site to show multiple authors Display author names throughout site, refactor to simpler author keys May 22, 2026
Comment thread _includes/page__meta.html
@@ -1,6 +1,19 @@
{% assign document = post | default: page %}
{% if document.read_time or document.show_date %}
{% assign authors = document.authors | default: document.author %}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

y'know after all this... I think since Liquid treats a string as a list of a single string, we could have just supported author: as the key. Actually I guess this ends up just supporting either authors: or author: in the metadata, which isn't terrible.

Comment thread _includes/page__meta.html Outdated
Copy link
Copy Markdown
Contributor

@oscarlevin oscarlevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo the extra nested if statement.

@StevenClontz
Copy link
Copy Markdown
Contributor Author

StevenClontz commented May 22, 2026 via email

@oscarlevin oscarlevin merged commit 8a1afcd into main May 22, 2026
1 check passed
@oscarlevin oscarlevin deleted the StevenClontz/20260522/fix-authors branch May 22, 2026 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use simple author keys

2 participants