Rename the vendor namespace to MathiasGrimm - #25
Merged
Conversation
Mathiasgrimm\Netwatch becomes MathiasGrimm\Netwatch, matching the PSR-4 convention for vendor namespaces and the casing the other mathiasgrimm packages use. The mixed casing also broke Wayfinder's generated action directories on case-insensitive filesystems, where MathiasGrimm/ and Mathiasgrimm/ collapse into one mangled directory. Breaking change: consumers must update their imports. Release as v2.0.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Mathiasgrimm\NetwatchbecomesMathiasGrimm\Netwatcheverywhere (src, tests, stubs, docs, README, composer autoload, the Laravel provider registration). The Composer package name staysmathiasgrimm/netwatch.Why
PSR-4 vendor namespaces are StudlyCaps per word (
NunoMaduro\,BeyondCode\), and the other packages already useMathiasGrimm\(Puff). The mixed casing is not just cosmetic: PHP resolves namespaces case-insensitively, but Wayfinder writes one generated directory per vendor segment, and on macOS's case-insensitive filesystemMathiasGrimm/andMathiasgrimm/collapse into one directory whose index gets mangled, breakingnpm run types:checkin glimpseimg.com locally.Breaking change
Consumers must update imports. Release as v2.0.0. A follow-up PR in glimpseimg.com updates
config/netwatch.phpand the composer constraint; its lock bump needs this tag first.132 tests pass.
🤖 Generated with Claude Code