Pin PHP 8.5 in the scaffolded workflow - #42
Closed
mathiasgrimm wants to merge 1 commit into
Closed
Conversation
The template relied on the runner image's default PHP, which is 8.4 today and drifts with the image. Pinning the newest stable with setup-php makes the check deterministic and costs a few seconds. Stacked on feat/public-token-fallback so the template only changes once per release chain; merge after PR 39. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #39 (merge that first; this PR then retargets to main). Parallel to #41, no overlap with the namespace rename.
The scaffolded workflow relied on the runner image's default PHP, which is 8.4 today and changes when GitHub updates the image. This adds a setup-php step pinning 8.5, so the check runs on the newest stable and behaves the same on every runner. The step costs a few seconds.
The companion docs update is stacked on the docs PR of this chain (glimpseimg.com #78), so the docs-drift check stays in lockstep.
🤖 Generated with Claude Code