Remove obsolete constructs, add until inversion.#39
Open
Artoria2e5 wants to merge 1 commit into
Open
Conversation
Removing obsolete constructs like `$[ expr ]` and `sleep NUMs` makes the script more portable, or at least easier to port to ksh and other POSIX shells as well as environments with other types of `sleep` (POSIX `sleep` doesn't require accepting suffixes.) I have also added comments for users/screwers of other shells. Unfortunately I am too lazy to write those `if [ "$BASH" ]` code, and not to mention that figuring out if a shell is ksh and its version can be tricky.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing obsolete constructs like
$[ expr ]andsleep NUMsmakes the script more portable, or at least easier to port to ksh and other POSIX shells as well as environments with other types ofsleep(POSIXsleepdoesn't require accepting suffixes.)I have also added comments for users/screwers of other shells. Unfortunately I am too lazy to write those
if [ "$BASH" ]code, and not to mention that figuring out if a shell is ksh and its version can be tricky.