fix #386#423
Open
gares wants to merge 6 commits into
Open
Conversation
Contributor
|
@gares could you try proux01@bc02eab |
Member
Author
|
done, but I think there was a "race" |
Contributor
|
Indeed, my bad, I rebased the branch, relaunching should now work. |
Member
Author
|
Now it works, but the OOthm fails (as in Coq's CI for your PR). |
Contributor
|
Bench is a bit disappointing, the last commit use primproj for class->mixin builders actually makes things a bit slower:
|
Member
|
I suspect a proper use of universe polymorphism will have a better impact. |
gares
commented
Dec 11, 2024
gares
force-pushed
the
fix-proj-ty-primproj
branch
from
5d9ee83 to
f0e45ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #386