Skip to content

pre-commit autoupdate#709

Open
pre-commit-ci[bot] wants to merge 1 commit into
mainfrom
pre-commit-ci-update-config
Open

pre-commit autoupdate#709
pre-commit-ci[bot] wants to merge 1 commit into
mainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci

@pre-commit-ci pre-commit-ci Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.15.12 → v0.15.15](astral-sh/ruff-pre-commit@v0.15.12...v0.15.15)
- [github.com/pre-commit/mirrors-mypy: v1.20.2 → v2.1.0](pre-commit/mirrors-mypy@v1.20.2...v2.1.0)
@shyuep

shyuep commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

🤖 Automated PR review (generated by Claude on behalf of @shyuep)

Dependency-only PR (ruff v0.15.12v0.15.15, mypy v1.20.2v2.1.0), but not safe to auto-merge — the updated hooks surface real failures that need fixes first:

  • ruff (RUF059, ×4): Unpacked fig, ax = plt.subplots(...) in notebooks/direct/Example1_MPF2021.2.8.all.ipynb (cell 18). Easy fix: rename to _fig, ax (or _, ax).
  • codespell (×many): New dictionary catches savsave typos in real source — src/maml/models/dl/_atomsets.py:266,315, tests/base/test_model.py:22,26,28,49,51,53, MANIFEST.in:3 — plus a handful of false positives in the notebooks/direct/Example2_Ti-H.ipynb and Example3_MatPES_2DIRECT.ipynb notebooks (HaV, ure, fPr, nED, sEh, hgE, Ue). The source-tree typos are worth fixing; the notebook noise likely needs a codespell ignore entry.
  • Test failure (test (ubuntu-latest, 3.11)): Unrelated — mp_api 401 against api.materialsproject.org (missing/expired MP API key in CI), not caused by the dep bump.

Recommend: fix the ruff RUF059 unpacks, run codespell -w on the source-tree hits, add ignore entries for the notebook false-positives, then merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant