feat(watch-settings): add global vibration pattern override for notifications and calendar#111
Merged
Merged
Conversation
…ications and calendar Adds two vibration pattern pickers to the Watch Settings screen — one for notifications and one for calendar reminders. Each picker shows the predefined DefaultVibePattern entries plus any user-created custom patterns. The selected pattern name is persisted via LibPebble.updateConfig() and applied automatically: notifications via the existing BasicNotificationProcessor priority chain, calendar events via the new vibePattern parameter on CalendarEvent.toTimelinePin() and toTimelineReminder() wired through PhoneCalendarSyncer. Bumps libpebble3 submodule to pick up the calendar vibration support.
Owner
|
Now that matejdro/libpebble3#2 has been pulled, do we need to update the submodule ref to point to the new merge now? Or will it work regardless? |
Contributor
Author
Functionally it works either way — |
Owner
|
I think it's fine. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two vibration pattern pickers to Watch Settings — one for notifications, one for calendar reminders. Each shows the bundled
DefaultVibePatternentries plus any user-created custom patterns, or "None" to fall back to the existing priority chain.The selected name persists via
LibPebble.updateConfig(). Notifications pick it up throughBasicNotificationProcessor's existing priority chain (global override is the lowest priority, so per-app/per-contact rules still win). Calendar reminders use a newvibePatternparameter onCalendarEvent.toTimelinePin()/toTimelineReminder(), wired throughPhoneCalendarSyncer.Pattern labels are localized via R.string while the upstream
displayNameis preserved as the storage /VibePatternDaokey.Depends on matejdro/libpebble3#2; submodule ref repoints to
origin/micropebbleafter that merges.Test plan
./gradlew verifyPaparazziDebugclean./gradlew :home:ui:runDebugDetekt :home:ui:lintReleaseclean