react_todo-app#1322
Open
valerij0412 wants to merge 3 commits into
Open
Conversation
brespect
suggested changes
Jun 12, 2026
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Almost done, add an error on submitting empty todo, also check this:
| import { useTodos } from '../context/TodoContext'; | ||
|
|
||
| export const TodoFooter: React.FC = () => { | ||
| // Дістаємо всі потрібні змінні та функції з Контексту |
| export const App: React.FC = () => { | ||
| const { todos } = useTodos(); // Дістаємо справи з Контексту | ||
|
|
||
| // Перевіряємо, чи є хоча б одна справа |
Comment on lines
+18
to
+43
| <nav className="filter" data-cy="Filter"> | ||
| <a | ||
| href="#/" | ||
| className={`filter__link ${filter === 'all' ? 'selected' : ''}`} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => setFilter('all')} | ||
| > | ||
| All | ||
| </a> | ||
| <a | ||
| href="#/active" | ||
| className={`filter__link ${filter === 'active' ? 'selected' : ''}`} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => setFilter('active')} | ||
| > | ||
| Active | ||
| </a> | ||
| <a | ||
| href="#/completed" | ||
| className={`filter__link ${filter === 'completed' ? 'selected' : ''}`} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => setFilter('completed')} | ||
| > | ||
| Completed | ||
| </a> | ||
| </nav> |
There was a problem hiding this comment.
you may simplify this using Array.map()
| <nav className="filter" data-cy="Filter"> | ||
| <a | ||
| href="#/" | ||
| className={`filter__link ${filter === 'all' ? 'selected' : ''}`} |
Anton-Kuchmasov
suggested changes
Jun 12, 2026
Anton-Kuchmasov
left a comment
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
Great job!
Just one tiny issue remaining!
Would you mind to fix this UI bug?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK