solution#1321
Open
jk-npc wants to merge 3 commits into
Open
Conversation
2pasha
suggested changes
Jun 12, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good job! 👏
here are some improvements:
- fix inputs
- pass all tests
- take a look on comments below
Comment on lines
+10
to
+35
| <a | ||
| href="#/" | ||
| className={`filter__link ${filter === 'all' ? 'selected' : ''}`} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => onChange('all')} | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/active" | ||
| className={`filter__link ${filter === 'active' ? 'selected' : ''}`} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => onChange('active')} | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/completed" | ||
| className={`filter__link ${filter === 'completed' ? 'selected' : ''}`} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => onChange('completed')} | ||
| > | ||
| Completed | ||
| </a> |
There was a problem hiding this comment.
you may add all your filter values to some array and map through it to avoid code duplication
Comment on lines
+48
to
+51
| onSubmit={e => { | ||
| e.preventDefault(); | ||
| handleSubmit(); | ||
| }} |
…on, input SCSS styles and port 3001 conflict
Anton-Kuchmasov
suggested changes
Jun 13, 2026
Anton-Kuchmasov
left a comment
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
UI bug didn't fixed yet. Would you mind to do this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK