Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,4 @@ Implement a simple [TODO app](https://mate-academy.github.io/react_todo-app/) th
- Implement a solution following the [React task guidelines](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline).
- Use the [React TypeScript cheat sheet](https://mate-academy.github.io/fe-program/js/extra/react-typescript).
- Open another terminal and run tests with `npm test` to ensure your solution is correct.
- Replace `<your_account>` with your GitHub username in the [DEMO LINK](https://<your_account>.github.io/react_todo-app/) and add it to the PR description.
- Replace `<your_account>` with your GitHub username in the [DEMO LINK](https://whomngmnt.github.io/react_todo-app/) and add it to the PR description.
174 changes: 27 additions & 147 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,157 +1,37 @@
/* eslint-disable jsx-a11y/control-has-associated-label */
import React from 'react';
import { useContext } from 'react';
import { Footer } from './components/Footer/Footer';
import { Header } from './components/Header/Header';
import { TodoContext, TodoProvider } from './components/Context/TodoContext';
import { TodoList } from './components/TodoList/TodoList';

const TodoApp = () => {
const context = useContext(TodoContext);

if (!context) {
return null;
}

const hasTodos = context.state.todos.length > 0;

export const App: React.FC = () => {
return (
<div className="todoapp">
<h1 className="todoapp__title">todos</h1>

<div className="todoapp__content">
<header className="todoapp__header">
{/* this button should have `active` class only if all todos are completed */}
<button
type="button"
className="todoapp__toggle-all active"
data-cy="ToggleAllButton"
/>

{/* Add a todo on form submit */}
<form>
<input
data-cy="NewTodoField"
type="text"
className="todoapp__new-todo"
placeholder="What needs to be done?"
/>
</form>
</header>

<section className="todoapp__main" data-cy="TodoList">
{/* This is a completed todo */}
<div data-cy="Todo" className="todo completed">
<label className="todo__status-label">
<input
data-cy="TodoStatus"
type="checkbox"
className="todo__status"
checked
/>
</label>

<span data-cy="TodoTitle" className="todo__title">
Completed Todo
</span>

{/* Remove button appears only on hover */}
<button type="button" className="todo__remove" data-cy="TodoDelete">
×
</button>
</div>

{/* This todo is an active todo */}
<div data-cy="Todo" className="todo">
<label className="todo__status-label">
<input
data-cy="TodoStatus"
type="checkbox"
className="todo__status"
/>
</label>

<span data-cy="TodoTitle" className="todo__title">
Not Completed Todo
</span>

<button type="button" className="todo__remove" data-cy="TodoDelete">
×
</button>
</div>

{/* This todo is being edited */}
<div data-cy="Todo" className="todo">
<label className="todo__status-label">
<input
data-cy="TodoStatus"
type="checkbox"
className="todo__status"
/>
</label>

{/* This form is shown instead of the title and remove button */}
<form>
<input
data-cy="TodoTitleField"
type="text"
className="todo__title-field"
placeholder="Empty todo will be deleted"
value="Todo is being edited now"
/>
</form>
</div>

{/* This todo is in loadind state */}
<div data-cy="Todo" className="todo">
<label className="todo__status-label">
<input
data-cy="TodoStatus"
type="checkbox"
className="todo__status"
/>
</label>

<span data-cy="TodoTitle" className="todo__title">
Todo is being saved now
</span>

<button type="button" className="todo__remove" data-cy="TodoDelete">
×
</button>
</div>
</section>

{/* Hide the footer if there are no todos */}
<footer className="todoapp__footer" data-cy="Footer">
<span className="todo-count" data-cy="TodosCounter">
3 items left
</span>

{/* Active link should have the 'selected' class */}
<nav className="filter" data-cy="Filter">
<a
href="#/"
className="filter__link selected"
data-cy="FilterLinkAll"
>
All
</a>

<a
href="#/active"
className="filter__link"
data-cy="FilterLinkActive"
>
Active
</a>

<a
href="#/completed"
className="filter__link"
data-cy="FilterLinkCompleted"
>
Completed
</a>
</nav>

{/* this button should be disabled if there are no completed todos */}
<button
type="button"
className="todoapp__clear-completed"
data-cy="ClearCompletedButton"
>
Clear completed
</button>
</footer>
<Header />
{hasTodos && (
<>
<TodoList />
<Footer />
</>
)}
</div>
</div>
);
};

export const App = () => (
<TodoProvider>
<TodoApp />
</TodoProvider>
);
66 changes: 66 additions & 0 deletions src/components/Context/TodoContext.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
import {
createContext,
Dispatch,
ReactNode,
useEffect,
useReducer,
} from 'react';
import { Todo } from '../../types/type';
import { Action, todoReducer } from './TodoReducer';

export type FilterStatus = 'all' | 'active' | 'completed';

export type TodoState = {
todos: Todo[];
filter: FilterStatus;
};

type TodoContextValue = {
state: TodoState;
dispatch: Dispatch<Action>;
};

const STORAGE_KEY = 'todos';

const getInitialState = (): TodoState => {
const savedTodos = localStorage.getItem(STORAGE_KEY);

if (!savedTodos) {
return {
todos: [],
filter: 'all',
};
}

try {
return {
todos: JSON.parse(savedTodos) as Todo[],
filter: 'all',
};
} catch {
return {
todos: [],
filter: 'all',
};
}
};

export const TodoContext = createContext<TodoContextValue | null>(null);

type Props = {
children: ReactNode;
};

export const TodoProvider = ({ children }: Props) => {
const [state, dispatch] = useReducer(todoReducer, undefined, getInitialState);

useEffect(() => {
localStorage.setItem(STORAGE_KEY, JSON.stringify(state.todos));
}, [state.todos]);

return (
<TodoContext.Provider value={{ state, dispatch }}>
{children}
</TodoContext.Provider>
);
};
73 changes: 73 additions & 0 deletions src/components/Context/TodoReducer.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
import type { FilterStatus, TodoState } from './TodoContext';

type UpdateTodoPayload = {
id: number;
title?: string;
completed?: boolean;
};

export type Action =

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also can describe Actions as Enum (not critical)

| { type: 'add'; payload: string }
| { type: 'delete'; payload: number }
| { type: 'update'; payload: UpdateTodoPayload }
| { type: 'setFilter'; payload: FilterStatus }
| { type: 'toggleAll' }
| { type: 'clearCompleted' };

export const todoReducer = (state: TodoState, action: Action): TodoState => {
switch (action.type) {
case 'add':
return {
...state,
todos: [
...state.todos,
{
id: +new Date(),
title: action.payload,
completed: false,
},
],
};

case 'delete':
return {
...state,
todos: state.todos.filter(todo => todo.id !== action.payload),
};

case 'update':
return {
...state,
todos: state.todos.map(todo =>
todo.id === action.payload.id ? { ...todo, ...action.payload } : todo,
),
};

case 'setFilter':
return {
...state,
filter: action.payload,
};

case 'toggleAll': {
const shouldCompleteAll = state.todos.some(todo => !todo.completed);

return {
...state,
todos: state.todos.map(todo => ({
...todo,
completed: shouldCompleteAll,
})),
};
}

case 'clearCompleted':
return {
...state,
todos: state.todos.filter(todo => !todo.completed),
};

default:
return state;
}
};
38 changes: 38 additions & 0 deletions src/components/Filter/Filter.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import { useContext } from 'react';
import { FilterStatus, TodoContext } from '../Context/TodoContext';

const filters: { label: string; value: FilterStatus; dataCy: string }[] = [

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you can use Enum for value in this case.

{ label: 'All', value: 'all', dataCy: 'FilterLinkAll' },
{ label: 'Active', value: 'active', dataCy: 'FilterLinkActive' },
{ label: 'Completed', value: 'completed', dataCy: 'FilterLinkCompleted' },
];

export const Filter = () => {
const context = useContext(TodoContext);

if (!context) {
return null;
}

const { filter } = context.state;
const { dispatch } = context;

return (
<nav className="filter" data-cy="Filter">
{filters.map(item => (
<a
key={item.value}
href={`#/${item.value === 'all' ? '' : item.value}`}
className={`filter__link ${filter === item.value ? 'selected' : ''}`}
data-cy={item.dataCy}
onClick={event => {
event.preventDefault();
dispatch({ type: 'setFilter', payload: item.value });
}}
>
{item.label}
</a>
))}
</nav>
);
};
File renamed without changes.
Loading
Loading