version 1#2410
Open
dianakomar wants to merge 3 commits into
Open
Conversation
etojeDenys
suggested changes
Jun 19, 2026
etojeDenys
left a comment
etojeDenys
left a comment
There was a problem hiding this comment.
good job, to improve:
- split the app into several components
| useEffect(() => { | ||
| getTodos() | ||
| .then(setTodos) | ||
| .catch(() => showErrorMessage('Unable to load todos')); |
There was a problem hiding this comment.
it would be better to create an enum for errors
Comment on lines
+112
to
+143
| <a | ||
| href="#/" | ||
| className={classNames('filter__link', { | ||
| selected: filter === 'All', | ||
| })} | ||
| data-cy="FilterLinkAll" | ||
| onClick={() => setFilter('All')} | ||
| > | ||
| All | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/active" | ||
| className={classNames('filter__link', { | ||
| selected: filter === 'Active', | ||
| })} | ||
| data-cy="FilterLinkActive" | ||
| onClick={() => setFilter('Active')} | ||
| > | ||
| Active | ||
| </a> | ||
|
|
||
| <a | ||
| href="#/completed" | ||
| className={classNames('filter__link', { | ||
| selected: filter === 'Completed', | ||
| })} | ||
| data-cy="FilterLinkCompleted" | ||
| onClick={() => setFilter('Completed')} | ||
| > | ||
| Completed | ||
| </a> |
There was a problem hiding this comment.
you can create an array with the needed parameters and then map through it to create links and avoid code repetition
…created an array for links
Denys-Kravchuk9988
suggested changes
Jun 20, 2026
Denys-Kravchuk9988
left a comment
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Good job!
A few things to improve:
| <div | ||
| key={todo.id} | ||
| data-cy="Todo" | ||
| className={`todo ${todo.completed ? 'completed' : ''}`} |
There was a problem hiding this comment.
It's better to use classNames here
| <div | ||
| data-cy="ErrorNotification" | ||
| className="notification is-danger is-light has-text-weight-normal" | ||
| className={`notification is-danger is-light has-text-weight-normal ${!error ? 'hidden' : ''}`} |
There was a problem hiding this comment.
It's better to use classNames here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://dianakomar.github.io/react_todo-app-loading-todos/