Skip to content

Solution#1237

Open
ExtymAndriy wants to merge 1 commit into
mate-academy:masterfrom
ExtymAndriy:develop
Open

Solution#1237
ExtymAndriy wants to merge 1 commit into
mate-academy:masterfrom
ExtymAndriy:develop

Conversation

@ExtymAndriy

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your Redux implementation successfully meets all task requirements. All five required slices (users, author, posts, selectedPost, comments) are properly implemented with correct state structures and async thunks. The UsersContext has been correctly removed with users now managed via Redux, the visible state is properly kept in PostDetails using useState, and all slices follow Redux Toolkit patterns with proper TypeScript typing. One minor cleanup recommendation: the counterReducer import in src/app/store.ts is leftover template code since the task focuses on posts and users. You should remove this import and the counter entry from the reducer configuration object to keep the store aligned with the task requirements. This is not a blocker, but cleaning it up will make your code more maintainable.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/app/store.ts
Comment on lines 2 to 3
// eslint-disable-next-line import/no-cycle
import counterReducer from '../features/counter/counterSlice';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The counterReducer is imported and registered in the store, but there's no evidence it being used in the application. According to the task requirements, this should be a React + Redux app for posts/users, not counters. Consider removing this if it's a leftover from a template.

Comment thread src/app/store.ts
Comment on lines 11 to 12
reducer: {
counter: counterReducer,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The counter reducer is still included in the store configuration. Since the task is about posts and users, this appears to be leftover template code. Remove it to keep the store clean and aligned with the task requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants