Skip to content

Solution #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Klemjl wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Solution #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d178560
Solution
Klemjl Jun 18, 2026
6c4a748
Solution
Klemjl Jun 18, 2026
44f66a6
Solution
Klemjl Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .idea/.gitignore
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/inspectionProfiles/profiles_settings.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions .idea/misc.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .idea/modules.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .idea/rda_task_3_transactions.iml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/vcs.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 6 additions & 9 deletions task.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
-- Use our database
USE ShopDB;

-- Some data should be created outside the transaction (here)

-- Start the transaction
START TRANSACTION;

-- And some data should be created inside the transaction
USE ShopDB;

INSERT INTO Orders (CustomerID, Date) VALUES (1, '2023-01-01');

@mateacademy-ai-mentor mateacademy-ai-mentor Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per checklist item #18 and the previous review, the Orders table insert is still executed before the transaction rather than after COMMIT;. The tests expect the order creation to happen outside and after the transactional block that handles OrderItems and Products, so you should move this statement below COMMIT;.

SET @OrderID = LAST_INSERT_ID();

@mateacademy-ai-mentor mateacademy-ai-mentor Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LAST_INSERT_ID() here depends on the order row inserted above, but both are currently before START TRANSACTION;. According to the requirements, the order creation and retrieval of its ID should happen after the transaction that inserts into OrderItems and updates Products has been committed, so this statement should also be moved to follow COMMIT;.

START TRANSACTION;
INSERT INTO OrderItems (OrderID, ProductID, Count) VALUES (@OrderID, 1, 1);
UPDATE Products SET WarehouseAmount = WarehouseAmount - 1 WHERE ID = 1;
COMMIT;
Loading