Skip to content

Solution #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nook17n1 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Solution #181

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b57406
Solution
nook17n1 May 26, 2026
7513961
Solution1
nook17n1 May 26, 2026
711a1e8
Solution2
nook17n1 May 26, 2026
77a5da9
Solution2
nook17n1 May 26, 2026
cfe7ae6
Solution2
nook17n1 May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion task.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@ USE ShopDB;

-- Some data should be created outside the transaction (here)

@mateacademy-ai-mentor mateacademy-ai-mentor May 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment incorrectly suggests Orders should be created outside the transaction. Based on the business rules, all three operations (Orders, OrderItems, Products update) must succeed or fail together. The START TRANSACTION should come immediately after USE ShopDB;.


INSERT INTO Orders (CustomerID, Date)
VALUES (1, "2023-01-01");
Comment on lines +6 to +7

@mateacademy-ai-mentor mateacademy-ai-mentor May 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this INSERT INTO Orders statement inside the transaction. It must come after START TRANSACTION (line 9) and before the OrderItems insert. Currently, if the OrderItems or Products update fails, you'll have an orphaned order with no items — violating transactional atomicity.

-- Start the transaction
START TRANSACTION;

INSERT INTO OrderItems (OrderID, ProductID, Count)

@mateacademy-ai-mentor mateacademy-ai-mentor May 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded OrderID = 1 will fail if the database has existing orders. Use LAST_INSERT_ID() to get the ID of the order just created in this session.

VALUES (LAST_INSERT_ID(), 1, 1);
UPDATE Products SET WarehouseAmount = WarehouseAmount - 1 where Name = "AwersomeProduct";
-- And some data should be created inside the transaction

COMMIT;
Loading