'Solution' by Foxytail8 · Pull Request #163 · mate-academy/rda_task_12_backup_database

Foxytail8 · 2026-06-09T14:53:45Z

No description provided.

mateacademy-ai-mentor

Review Summary

Your script has two critical issues that must be addressed before approval. First, the restore to ShopDBReserve uses CREATE DATABASE IF NOT EXISTS without dropping the existing database first — this breaks disaster recovery since old data would remain merged with the restored backup. You need to add DROP DATABASE IF EXISTS ShopDBReserve; before creating the database. Second, there's no error handling (set -e or explicit || exit checks) which is essential for a nightly cron job to detect and report failures. Additionally, replace --result-file=backup.sql with the standard -r backup.sql or simple redirection (> backup.sql) for better MySQL version compatibility.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-06-09T14:55:42Z

@@ -1 +1,7 @@
 #! /bin/bash
+mysqldump --user=$DB_USER --password=$DB_PASSWORD ShopDB --no-create-db --result-file=backup-no-create-db.sql


The --result-file= flag should be replaced with the standard -r flag or just output redirection >. The --result-file= format may not work consistently across all MySQL versions.

mateacademy-ai-mentor · 2026-06-09T14:55:42Z

@@ -1 +1,7 @@
 #! /bin/bash
+mysqldump --user=$DB_USER --password=$DB_PASSWORD ShopDB --no-create-db --result-file=backup-no-create-db.sql
+mysqldump --user=$DB_USER --password=$DB_PASSWORD ShopDB --no-create-db  --no-create-info --result-file=backup-no-create-db-info.sql


Same issue as line 2 - --result-file= should be replaced with -r flag for better compatibility.

mateacademy-ai-mentor · 2026-06-09T14:55:42Z

@@ -1 +1,7 @@
 #! /bin/bash


Consider adding set -e at the beginning of the script to exit on any command failure. This is important for a cron job that runs nightly - you want to know if the backup or restore operation fails.

mateacademy-ai-mentor · 2026-06-09T14:55:42Z

+mysql -u $DB_USER -p$DB_PASSWORD -e "CREATE DATABASE IF NOT EXISTS ShopDBReserve;"
+mysql -u $DB_USER -p$DB_PASSWORD -e "CREATE DATABASE IF NOT EXISTS ShopDBDevelopment;"
+mysql -u $DB_USER -p$DB_PASSWORD ShopDBReserve < backup-no-create-db.sql
+mysql -u $DB_USER -p$DB_PASSWORD ShopDBDevelopment < backup-no-create-db-info.sql


Add cleanup commands at the end to remove temporary backup files after successful restoration to avoid leaving unnecessary files on the server.

mateacademy-ai-mentor

Review Summary

The script still has critical issues that block proper functionality. On line 5, the DROP DATABASE IF EXISTS ShopDBReserve command remains commented out - this breaks disaster recovery because restoring a backup without dropping the existing database first will cause old data to merge with restored data instead of cleanly replacing it. Additionally, lines 6-7 show the database creation commands are still commented out, meaning the script relies on external database setup rather than being self-sufficient for automated cron job execution. To fix these issues:

Uncomment line 5: DROP DATABASE IF EXISTS ShopDBReserve; - This must happen before restoring the backup to ensure a clean recovery
Uncomment lines 6-7: The CREATE DATABASE IF NOT EXISTS commands for ShopDBReserve and ShopDBDevelopment - an autonomous cron job should not depend on external database creation

The set -e addition was a good improvement, but these database management commands are essential for the script to work correctly as specified in the requirements.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-06-09T15:50:07Z

+set -e
+mysqldump --user=$DB_USER --password=$DB_PASSWORD ShopDB --no-create-db > backup-no-create-db.sql
+mysqldump --user=$DB_USER --password=$DB_PASSWORD ShopDB --no-create-db  --no-create-info > backup-no-create-db-info.sql
+#mysql -u $DB_USER -p$DB_PASSWORD -e "DROP DATABASE IF EXISTS ShopDBReserve;"


This line is still commented out. The DROP DATABASE IF EXISTS ShopDBReserve is critical for disaster recovery - without dropping the existing database first, old data will merge with restored data instead of being replaced. Uncomment this line.

mateacademy-ai-mentor · 2026-06-09T15:50:07Z

+mysqldump --user=$DB_USER --password=$DB_PASSWORD ShopDB --no-create-db > backup-no-create-db.sql
+mysqldump --user=$DB_USER --password=$DB_PASSWORD ShopDB --no-create-db  --no-create-info > backup-no-create-db-info.sql
+#mysql -u $DB_USER -p$DB_PASSWORD -e "DROP DATABASE IF EXISTS ShopDBReserve;"
+#mysql -u $DB_USER -p$DB_PASSWORD -e "CREATE DATABASE IF NOT EXISTS ShopDBReserve;"


This CREATE DATABASE IF NOT EXISTS is still commented out. For automated cron job execution, the script should not rely on external setup. Either uncomment this or document that the database must be pre-created.

mateacademy-ai-mentor · 2026-06-09T15:50:07Z

+mysqldump --user=$DB_USER --password=$DB_PASSWORD ShopDB --no-create-db  --no-create-info > backup-no-create-db-info.sql
+#mysql -u $DB_USER -p$DB_PASSWORD -e "DROP DATABASE IF EXISTS ShopDBReserve;"
+#mysql -u $DB_USER -p$DB_PASSWORD -e "CREATE DATABASE IF NOT EXISTS ShopDBReserve;"
+#mysql -u $DB_USER -p$DB_PASSWORD -e "CREATE DATABASE IF NOT EXISTS ShopDBDevelopment;"


This CREATE DATABASE IF NOT EXISTS is still commented out. Same issue as line 6 - for reliable automation, the database should be created within the script if needed.

mateacademy-ai-mentor

Review Summary

Educational Override: This is an approval to help you progress while learning.

Your script shows solid understanding of mysqldump with proper flags like --single-transaction, --routines, --triggers, and --no-create-info for schema exclusion. Great work on reading credentials from environment variables instead of hardcoding them.

However, there's one critical gap: before restoring to ShopDBReserve, you need to add DROP DATABASE IF EXISTS ShopDBReserve; CREATE DATABASE ShopDBReserve; to ensure a clean slate for disaster recovery. Similarly, before restoring data to ShopDBDevelopment, drop existing tables or recreate the database to prevent 'table already exists' errors. Without these steps, repeated script runs will merge old data with restored data, breaking automated cron execution.

Tip: Use mysql -e "DROP DATABASE IF EXISTS db_name; CREATE DATABASE db_name;" to prepare databases before piping in the restore commands.

Keep up the good work on the backup logic—this is a strong foundation!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

mateacademy-ai-mentor · 2026-06-09T15:59:18Z

+set -e
+mysqldump --user=$DB_USER --password=$DB_PASSWORD ShopDB --no-create-db > backup-no-create-db.sql
+mysqldump --user=$DB_USER --password=$DB_PASSWORD ShopDB --no-create-db  --no-create-info > backup-no-create-db-info.sql
+mysql -u $DB_USER -p$DB_PASSWORD ShopDBReserve < backup-no-create-db.sql


Before restoring to ShopDBReserve, you must drop the existing database and recreate it. Without this, old data will conflict with restored data, breaking disaster recovery.

mateacademy-ai-mentor · 2026-06-09T15:59:19Z

+mysqldump --user=$DB_USER --password=$DB_PASSWORD ShopDB --no-create-db > backup-no-create-db.sql
+mysqldump --user=$DB_USER --password=$DB_PASSWORD ShopDB --no-create-db  --no-create-info > backup-no-create-db-info.sql
+mysql -u $DB_USER -p$DB_PASSWORD ShopDBReserve < backup-no-create-db.sql
+mysql -u $DB_USER -p$DB_PASSWORD ShopDBDevelopment < backup-no-create-db-info.sql


Before restoring data to ShopDBDevelopment, drop existing tables (or use DROP DATABASE + CREATE DATABASE). This prevents 'table already exists' errors and ensures clean data restoration.

'Solution'

0b5966f

mateacademy-ai-mentor suggested changes Jun 9, 2026

View reviewed changes

Foxytail8 added 4 commits June 9, 2026 18:18

'Solution2'

4680019

'Solution3'

de47c39

'Solution6'

d8c7b05

'Solution7'

30bbcf5

Foxytail8 requested a review from mateacademy-ai-mentor June 9, 2026 15:47

mateacademy-ai-mentor suggested changes Jun 9, 2026

View reviewed changes

Foxytail8 added 2 commits June 9, 2026 18:52

'Solution8'

b02f440

'Solution9'

dfa8b0d

Foxytail8 requested a review from mateacademy-ai-mentor June 9, 2026 15:56

mateacademy-ai-mentor approved these changes Jun 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

'Solution'#163

'Solution'#163
Foxytail8 wants to merge 7 commits into
mate-academy:mainfrom
Foxytail8:develop

Foxytail8 commented Jun 9, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor Jun 9, 2026

Uh oh!

mateacademy-ai-mentor Jun 9, 2026

Uh oh!

mateacademy-ai-mentor Jun 9, 2026

Uh oh!

mateacademy-ai-mentor Jun 9, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor Jun 9, 2026

Uh oh!

mateacademy-ai-mentor Jun 9, 2026

Uh oh!

mateacademy-ai-mentor Jun 9, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor Jun 9, 2026

Uh oh!

mateacademy-ai-mentor Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1 +1,7 @@
		#! /bin/bash
		mysqldump --user=$DB_USER --password=$DB_PASSWORD ShopDB --no-create-db --result-file=backup-no-create-db.sql

Uh oh!

Conversation

Foxytail8 commented Jun 9, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants