solution by ten4i#158
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The task.sh script has a critical typo on line 2: mysqldldump instead of mysqldump. This extra 'd' will cause the command to fail with "command not found", breaking the full backup to ShopDBReserve. Please change mysqldldump to mysqldump on line 2 to fix this issue. The rest of the script correctly implements the requirements - reading credentials from environment variables, creating a full backup for ShopDBReserve, and creating a data-only backup with --no-create-info for ShopDBDevelopment.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. All previously identified issues have been resolved. The mysqldump typo has been fixed across all files, and your script correctly implements the backup strategy: reading credentials from environment variables, creating a full backup for ShopDBReserve, and using --no-create-info to create a data-only backup for ShopDBDevelopment without copying the schema. All checklist items pass successfully. Great work completing this task!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.