qa_restore-names:master#349
Open
sonik-boom71 wants to merge 2 commits into
Open
Conversation
test: add unit tests for restoreNames function
mateacademy-ai-mentor
approved these changes
May 25, 2026
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your test file fully satisfies all task requirements. The tests properly cover the restoreNames function with 8 test cases including edge cases like empty arrays, existing firstName values, undefined firstName, extracting the first word from fullName, and handling multiple users. The tests correctly verify that the function mutates the input array in place rather than returning a new array. All requirements from the task description are implemented correctly using Jest's describe/it/expect syntax with appropriate matchers. No critical issues were found.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Написаны 8 unit-тестов в src/restoreNames.test.js, покрывающих:
пустой массив
пользователь с уже заданным firstName (не изменяется)
пользователь без firstName — восстанавливается из fullName
пользователь с пустым firstName ('') — тоже восстанавливается
fullName из нескольких слов — берётся только первое
fullName из одного слова
массив из нескольких пользователей без firstName
смешанный массив (с и без firstName)