Set up automatic code checks by petryniy1 · Pull Request #92 · mate-academy/qa_pw_conduit_code_checks

petryniy1 · 2026-07-03T12:13:14Z

Summary

Added helper for signInPositive.spec
Set up ESLint configuration
Set up Prettier configuration
Added Husky pre-commit hook with lint-staged
Fixed linting and formatting issues
Added reusable user creation helper for stable sign-in tests

Checks

npx eslint
npx prettier ./ --check
npx playwright test

mateacademy-ai-mentor

Review Summary

I am requesting changes because some core tooling requirements from the task are not yet correctly met. The ESLint flat config in eslint.config.mjs mixes pluginJs.configs.recommended and playwright.configs['flat/recommended'] in a single object and then also spreads both of their rules objects into rules, which can cause unintended rule overrides and violates ESLint flat-config composition guidance [CHECKLIST ITEM #1]. You also place ignores inside that same config object instead of a dedicated top-level config entry, so the ignore patterns may not be applied as expected across the project [CHECKLIST ITEM #1]. In addition, there is no visible Prettier configuration file nor Husky/Lint-Staged setup in the shared code, while the task explicitly requires both to be configured and integrated so ESLint (and ideally Prettier) run on staged files before commit [CHECKLIST ITEM #2, #3, #4].

Critical issues to fix:

In eslint.config.mjs, separate the Playwright and base JS configs into distinct entries in the exported array or start from one and selectively extend its rules, instead of double-spreading full configs and their rules objects; also move ignores into its own top-level config object so ESLint respects them globally. For example, have one entry like { ignores: ['dist', 'node_modules'] } and then subsequent entries for your main JS rules and your Playwright rules. - Add a Prettier configuration (e.g., .prettierrc or prettier.config.mjs) that follows the theory instructions and ensure it’s wired into your workflow (typically via lint-staged), so formatting is enforced consistently. - Configure Husky and Lint-Staged (e.g., .husky/pre-commit running npx lint-staged, and a lint-staged section in package.json that runs eslint and Prettier on staged files) so commits are blocked when ESLint errors exist, as required.

Your page objects and tests look syntactically clean and should work well once the tooling configuration is corrected, so you’re close to the goal. Focus on fixing the ESLint flat config structure and adding the missing Prettier and Husky/Lint-Staged wiring, and you’ll have a solid, standards-compliant setup.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-07-03T12:13:56Z

+  {
+    ...pluginJs.configs.recommended,
+    ...playwright.configs['flat/recommended'],


The current flat config object spreads pluginJs.configs.recommended and playwright.configs['flat/recommended'] together and then also manually merges their rules. This can lead to conflicting or duplicated rule definitions and may not follow the structure from the theory instructions for combining multiple flat configs. Consider separating these into distinct config entries or using a single base config and extending its rules explicitly, aligning with the recommended setup.

mateacademy-ai-mentor · 2026-07-03T12:13:56Z

+    ignores: [
+      '**/node_modules/*',
+      'playwright.config.js',
+      '**/playwright-report/**',
+    ],


Placing ignores inside the same object that spreads other configs is not how the ignores option is typically used in flat config; it is usually defined in a dedicated config entry (e.g., a top-level object with just ignores) so that it applies cleanly to the whole project. This may prevent ESLint from ignoring the intended paths, which impacts checklist item #1: ONLY FOCUS ON ESLint configuration correctness.

mateacademy-ai-mentor · 2026-07-03T12:13:56Z

+  await request.post('/api/users', {
+    data: {
+      user,


The way configs are merged here (...pluginJs.configs.recommended and ...playwright.configs['flat/recommended']) together with separately spreading pluginJs.configs.recommended.rules and playwright.configs['flat/recommended'].rules inside rules can lead to duplicate/overwritten rule settings and deviates from typical flat-config usage recommended by ESLint and the Playwright plugin. This can violate checklist item #1 ("ESLint configuration correctness") and checklist item #4 ("ONLY FOCUS ON whether tools are working as expected"), because the effective rule set may not be what you expect. Consider composing these configs more explicitly (e.g., starting from one config and selectively extending its rules) instead of double-spreading entire configs and their rules objects.

mateacademy-ai-mentor · 2026-07-03T12:13:56Z

@@ -1,17 +1,17 @@
-import { expect } from "@playwright/test";
+import { expect } from '@playwright/test';


There is no Prettier configuration or integration visible in any of the files you’ve shared, which violates checklist item #2: "ONLY FOCUS ON Prettier configuration correctness". You need to provide a Prettier config (e.g., .prettierrc or prettier.config.*) and ensure it’s wired into your tooling workflow.

mateacademy-ai-mentor · 2026-07-03T12:13:56Z

@@ -1,17 +1,17 @@
-import { expect } from "@playwright/test";
+import { expect } from '@playwright/test';


There is no Husky or Lint-Staged setup visible (no .husky directory or lint-staged configuration in package.json or separate file), which violates checklist item #3: "ONLY FOCUS ON Husky and Lint-Staged setup correctness". You should add Husky pre-commit hooks and Lint-Staged configuration so ESLint (and optionally Prettier) runs on staged files before commit, blocking commits on ESLint errors as required in the task description.

mateacademy-ai-mentor

Review Summary

I am requesting changes because some core tooling requirements from the task are still missing or unclear in the code you shared. Specifically, there is no visible Prettier configuration file (such as .prettierrc or prettier.config.mjs), which violates the requirement to set up Prettier according to the theory and breaks the “Prettier configuration correctness” checklist item [CHECKLIST ITEM #2]. In addition, there is no .husky folder, no pre-commit hook, and no lint-staged configuration in package.json, so commits are not guaranteed to run ESLint/Prettier on staged files or be blocked when ESLint errors exist, which conflicts with the Husky/Lint-Staged setup requirements [CHECKLIST ITEM #3, #4]. Your eslint.config.mjs structure is much better now, but you should double‑check that spreading pluginJs.configs.recommended in a flat-config entry is intentional and doesn’t conflict with how the Playwright config is applied, so that your custom rules apply consistently to all JS and test files.

Critical fixes needed:

Add a Prettier configuration file (e.g., .prettierrc), plus .prettierignore if required, following the course/theory defaults, and ensure it’s used in your workflow.
Set up Husky with a .husky/pre-commit hook that runs lint-staged, and add a lint-staged section in package.json to run eslint (and ideally prettier) on staged files so commits fail when lint errors remain.
Review your eslint.config.mjs to ensure your custom rules are part of the same config entries as the recommended configs, and that the composition with Playwright’s flat config doesn’t unintentionally override language options or rules.

The Playwright helpers and tests themselves look good, and you’re close to meeting all requirements; once you add and wire up Prettier, Husky, and lint-staged correctly, your solution should fully satisfy the task.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-07-03T14:27:46Z

+  {
+  ...pluginJs.configs.recommended,


This violates checklist item: "ESLint configuration correctness" because spreading pluginJs.configs.recommended directly into this flat-config entry includes its own languageOptions and other fields, which you partially override. While the structure is mostly acceptable now, you should double-check against the theory instructions that this composition is intentional and does not conflict with how Playwright config is applied; otherwise rules or settings might not behave as expected.

mateacademy-ai-mentor · 2026-07-03T14:27:46Z

@@ -1,16 +1,16 @@
-import { expect, test } from "@playwright/test";
+import { expect } from '@playwright/test';


There is no Prettier configuration visible (e.g., .prettierrc, prettier.config.mjs, or equivalent), which violates the task requirement: "Set up Prettier using the instructions given in the theory section" and the checklist focus on "Prettier configuration correctness".

mateacademy-ai-mentor · 2026-07-03T14:27:46Z

@@ -1,16 +1,16 @@
-import { expect, test } from "@playwright/test";
+import { expect } from '@playwright/test';


There is no Husky/Lint-Staged setup visible (no .husky/pre-commit, .husky folder, or lint-staged config in package.json), which conflicts with the requirements: "Set up Husky and Lint-Staged using instructions given in the theory section" and the checklist items that focuses on these tools working as expected and blocking commits on ESLint errors.

mateacademy-ai-mentor · 2026-07-03T14:27:46Z

@@ -1,37 +1,39 @@
-import { test } from "@playwright/test";
-import { SignUpPage } from "../../src/pages/SignUpPage";
+import { test } from '@playwright/test';


There is still no visible Prettier configuration file (e.g., .prettierrc, prettier.config.mjs, etc.) or wiring into the workflow in the provided context, which conflicts with the task requirement: "Set up Prettier using the instructions given in the theory section" and the checklist focus on "Prettier configuration correctness".

mateacademy-ai-mentor · 2026-07-03T14:27:46Z

@@ -1,37 +1,39 @@
-import { test } from "@playwright/test";
-import { SignUpPage } from "../../src/pages/SignUpPage";
+import { test } from '@playwright/test';


There is no Husky pre-commit hook or lint-staged configuration visible (typically in .husky/pre-commit and package.json), which violates the requirement: "Set up Husky and Lint-Staged using instructions given in the theory section" and the constraint that commits must be blocked while ESLint errors remain.

mateacademy-ai-mentor

Review Summary

I am approving your solution as an educational override so you can keep progressing while you refine the tooling setup.

You did a solid job wiring ESLint, Prettier, Husky, and lint-staged overall, and your Playwright page objects and tests look clean and syntactically correct. The main area to improve is your eslint.config.mjs: right now you’re spreading pluginJs.configs.recommended and playwright.configs['flat/recommended'] into a single entry without scoping to test files, which can leak Playwright language options and rules into non-test code and conflicts with [CHECKLIST ITEM #1]. A good next step is to create separate flat config entries (e.g., one JS entry using pluginJs.configs.recommended plus your custom rules, and another entry for Playwright tests using playwright.configs['flat/recommended'] with a files pattern like tests/**/*.spec.js).

Also, you currently include eslintConfigPrettier as its own global config entry; to better align with the theory for [CHECKLIST ITEM #1] and [CHECKLIST ITEM #2], try merging it into the same entry (or same files scope) as your main JS config so it disables formatting rules exactly where your JS rules apply. Finally, double‑check that your Husky pre-commit hook and lint-staged command cause git commit to fail whenever eslint finds errors (for example, using eslint --max-warnings=0), to fully satisfy [CHECKLIST ITEMS #3 and #4]. Overall, you’re very close—these are refinement steps, not fundamental problems, and you should feel good about the progress you’ve made on this tooling setup.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

mateacademy-ai-mentor · 2026-07-05T14:16:53Z

+  {
+    ...pluginJs.configs.recommended,
+    ...playwright.configs['flat/recommended'],


This config entry spreads both pluginJs.configs.recommended and playwright.configs['flat/recommended'] into a single object without any files/overrides scoping, which may cause Playwright rules and language options to apply to non-test files. This conflicts with checklist item #1, which requires that the ESLint configuration composition with Playwright not unintentionally override language options or rules; consider separating or scoping the Playwright config so it applies only to test files as intended by the theory.

mateacademy-ai-mentor · 2026-07-05T14:16:53Z

+/** @type {import('eslint').Linter.Config[]} */
+export default [
+  { languageOptions: { globals: globals.node } },
+  eslintConfigPrettier,


eslintConfigPrettier is added as a standalone config entry with no files filter, while your JS/Playwright rules and ignores are defined in a separate entry below. This can make it unclear whether Prettier-related rule disabling is correctly aligned with the recommended configs and target files, which violates checklist item #1’s requirement that custom rules be part of the same config entries as the recommended configs. Consider merging eslintConfigPrettier into the same entry (or matching files scope) as your main JS config so it cleanly disables conflicting formatting rules for the intended files.

mateacademy-ai-mentor · 2026-07-05T14:16:54Z

  }

  async open() {


The current flat config spreads pluginJs.configs.recommended and playwright.configs['flat/recommended'] directly into a single config object. This can unintentionally mix or override languageOptions and other settings from Playwright’s flat config, which conflicts with checklist item #1: "ESLint configuration correctness" (and the description’s note about not unintentionally overriding language options). Consider using separate entries for JS and Playwright (e.g., one entry based on pluginJs.configs.recommended with your custom rules, and another entry extending playwright.configs['flat/recommended'] for test files), rather than merging the two config objects with spread.

mateacademy-ai-mentor · 2026-07-05T14:16:54Z

+    this.emailField = page.getByPlaceholder('Email');
+    this.passwordField = page.getByPlaceholder('Password');
+    this.signInButton = page.getByRole('button', { name: 'Sign in' });
+    this.errorMessage = page.getByRole('list').nth(1);


Because the checklist focuses on tooling, note that there is no Prettier configuration visible here (e.g., .prettierrc or prettier.config.mjs), which violates checklist item #2: "Prettier configuration correctness" and the description requirement to "Set up Prettier using the instructions given in the theory section." You should add a Prettier config file following the course defaults and ensure it is part of your workflow (often also referenced in lint-staged).

Set up automatic code checks

f00ca61

mateacademy-ai-mentor suggested changes Jul 3, 2026

View reviewed changes

petryniy1 added 2 commits July 3, 2026 14:19

Fix ESLint flat config structure

40c33ca

fix2

1ce1fc3

petryniy1 requested a review from mateacademy-ai-mentor July 3, 2026 14:27

mateacademy-ai-mentor suggested changes Jul 3, 2026

View reviewed changes

fix3

6eb8043

petryniy1 requested a review from mateacademy-ai-mentor July 5, 2026 14:15

mateacademy-ai-mentor approved these changes Jul 5, 2026

View reviewed changes

		@@ -1,17 +1,17 @@
		import { expect } from "@playwright/test";
		import { expect } from '@playwright/test';

		@@ -1,16 +1,16 @@
		import { expect, test } from "@playwright/test";
		import { expect } from '@playwright/test';

Uh oh!

Conversation

petryniy1 commented Jul 3, 2026

Summary

Checks

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants