task is done#70
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job setting up the project with ESLint, Prettier, and Husky! The overall structure is well-done. However, I'm requesting a couple of changes to fix some critical issues that prevent the requirements from being met.
- ESLint Configuration: In
eslint.config.mjs,eslint-config-prettiermust be the last item in the exported array. This ensures it correctly overrides formatting rules from other plugins, which is a key requirement of the setup [CHECKLIST ITEM #1]. - Test Bug: In
tests/signUp/signUpNegative.spec.js, a test will fail because the multi-line template literal for an error message includes unwanted whitespace and newlines. Please rewrite this as a single-line string to ensure the assertion passes.
Also, a small suggestion for tests/signUp/signUpPositive.spec.js: consider using faker.internet.userName() instead of faker.person.lastName() to generate more reliable usernames and avoid potential test flakiness.
Please fix the two required items, and I'll be happy to review it again!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| `username:Username must start with a letter, | ||
| have no spaces, and be 2 - 40 characters.`, |
There was a problem hiding this comment.
When you use a multi-line template literal like this, the newline character and the extra spaces on the second line become part of the string you're searching for. It's unlikely the actual error message contains this specific formatting. To fix this, you should write the expected error message as a single-line string.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! I am approving your submission as you've successfully addressed all the feedback from the previous review. The project is now robust and correctly configured, with the ESLint setup and test fixes properly implemented. Your use of the Page Object Model is clean and effective across all tests and page objects. All requirements have been met, great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.