Resolved#486
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on the overall structure with classes and inheritance! Your solution is very close. However, changes are needed because the strings returned by several methods do not exactly match the task requirements, which is a critical blocker for this task. Please adjust the return values in src/pageObject.js to remove extra spaces:
- In
clickOnLogoandclickOnCommentButton, the string should be'Click on the' + variable, with no space after 'the'. - In
assertPageOpened, the string should be'The ' + this.url + 'is opened', with no space between the URL and 'is opened'.
Fixing these small but crucial details will ensure your code passes the validation checks. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| }; | ||
| clickOnLogo() { | ||
| return 'Click on the ' + this.header.logo; |
There was a problem hiding this comment.
The return string needs to match the requirement precisely. The description specifies the return value as the result of 'Click on the' + logo, which means there should be no space after the word 'the'.
| } | ||
|
|
||
| clickOnCommentButton() { | ||
| return `Click on the ${this.commentButton}`; |
There was a problem hiding this comment.
Similar to the clickOnLogo method, the return string here should exactly match the requirement from the description: 'Click on the' + commentButton. This implies there should be no space after 'the'.
| } | ||
|
|
||
| assertPageOpened() { | ||
| return `The ` + this.url + ' is opened'; |
There was a problem hiding this comment.
The return string doesn't quite match the requirement. The description specifies 'The ' + url + 'is opened', which does not have a space between the URL part and the text 'is opened'.
3 participants
No description provided.