Solution#481
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because several string-returning methods do not match the exact concatenation format required by the task, which will cause strict automated checks to fail. In src/pageObject.js, your PageObject.clickOnLogo currently uses a template literal that produces "Click on the Conduit logo", but the requirement is to return 'Click on the' + this.header.logo with no extra space between the and the logo text [CHECKLIST ITEM #16]. Similarly, ArticlePage.clickOnCommentButton returns "Click on the [Publish comment] button", but the requirement is 'Click on the' + this.commentButton (again, no space between the and the button text) [CHECKLIST ITEM #18]. Finally, ArticlePage.assertPageOpened currently returns a string like "The <url> is opened", but the requirement is 'The ' + this.url + 'is opened', with no space between the URL and the word is [CHECKLIST ITEM #19]. Please change these three methods to use explicit string concatenation exactly as specified so the outputs match the required literals and tests can pass. Aside from these formatting issues, your class structure, inheritance, and property usage look good, so once you fix these strings you should be in great shape.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| } | ||
|
|
||
| clickOnLogo() { | ||
| return `Click on the ${this.header.logo}`; |
There was a problem hiding this comment.
The template literal here produces "Click on the Conduit logo" (note the space). Checklist item #16 requires the method to return 'Click on the' + logo (no extra space between the and the logo). Consider using explicit concatenation to match the exact required string: return 'Click on the' + this.header.logo;
| } | ||
|
|
||
| clickOnCommentButton() { | ||
| return `Click on the ${this.commentButton}`; |
There was a problem hiding this comment.
This returns "Click on the [Publish comment] button" (with a space). Checklist item #18 requires 'Click on the' + commentButton (no extra space). Use explicit concatenation to match the exact required string: return 'Click on the' + this.commentButton;
| } | ||
|
|
||
| assertPageOpened() { | ||
| return `The ${this.url} is opened`; |
There was a problem hiding this comment.
This template produces "The <url> is opened" (space before is). Checklist item #19 requires 'The ' + url + 'is opened' (no space between the URL and is). Change to explicit concatenation to match the exact required string: return 'The ' + this.url + 'is opened';
|
Це не вірно, завдання виконано у відповідності до тестів, тести вимагають саме наявності пробілів у повертаємих строках |
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
3 participants
No description provided.