Skip to content

solution#572

Open
aakash1sadhu wants to merge 1 commit into
mate-academy:mainfrom
aakash1sadhu:develop
Open

solution#572
aakash1sadhu wants to merge 1 commit into
mate-academy:mainfrom
aakash1sadhu:develop

Conversation

@aakash1sadhu

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your isIsogram implementation is correct and passes all existing tests. The core logic properly handles isogram detection including case-insensitivity and detecting repeating letters regardless of their position in the word. However, you'll need to add one missing test case. The task description explicitly lists isIsogram('Oops') === false as a reference example that should be tested. This verifies the function detects repeating letters like the double 'o' even when they aren't adjacent. Add a test for this to fully meet the requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/isIsogram.test.js

it('should return false for repeating letters in different cases', () => {
expect(isIsogram('Adam')).toBe(false);
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test case: the task description explicitly shows isIsogram('Oops') === false as an example that should be tested. This verifies the function detects repeating letters like the double 'o' in 'Oops'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants