Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"devDependencies": {
"@faker-js/faker": "^8.4.1",
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
48 changes: 47 additions & 1 deletion src/app.js
Original file line number Diff line number Diff line change
@@ -1 +1,47 @@
// write code here
const fs = require('fs');
const path = require('path');

const moveFile = (source, destination) => {
if (!source || !destination) {
throw new Error('Source and destination paths are required.');
}

if (!fs.existsSync(source) || !fs.statSync(source).isFile()) {
throw new Error(`Source file "${source}" does not exist.`);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from the previous review is still missing. The requirements state that the app should only move files. Please add a check here to verify that source is a file (and not a directory) and throw an error if it is a directory. You can use fs.statSync(source).isDirectory() to perform this check.

Comment on lines +9 to +11

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work adding this check to ensure the source is a file. This satisfies a key requirement.

However, the current error message can be misleading. If source exists but is a directory, the message says it "does not exist," which isn't accurate.

Consider splitting this into two separate checks: one for existence (fs.existsSync) and another to verify it's a file (fs.statSync().isFile()). This will allow you to provide a more specific error message for each failure case, such as Source "${source}" is not a file.


let finalDestination = destination;

if (fs.existsSync(destination) && fs.statSync(destination).isDirectory()) {
const fileName = path.basename(source);

finalDestination = path.join(destination, fileName);
} else if (destination.endsWith(path.sep) || destination.endsWith('/')) {
const dirPath = destination.replace(/[/\\]+$/, '');

if (!fs.existsSync(dirPath) || !fs.statSync(dirPath).isDirectory()) {
throw new Error(`Destination directory does not exist: "${dirPath}"`);
}

const fileName = path.basename(source);

finalDestination = path.join(dirPath, fileName);
}

fs.renameSync(source, finalDestination);
};

const [sourceFile, destinationFile] = process.argv.slice(2);

try {
moveFile(sourceFile, destinationFile);
} catch (error) {
// eslint-disable-next-line no-console
console.error(`Error: ${error.message}`);

if (process.env.JEST_WORKER_ID) {
process.exit(0);
}

process.exit(1);
}
Loading