-
Notifications
You must be signed in to change notification settings - Fork 573
Solution #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Solution #501
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm test |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,57 @@ | ||
| /* eslint-disable no-console */ | ||
| 'use strict'; | ||
|
|
||
| const fs = require('fs'); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You need to require the |
||
|
|
||
| const copy = () => { | ||
| const [src, dest] = process.argv.slice(2); | ||
|
|
||
| if (!src || !dest) { | ||
| console.error('Usage: node app.js <src> <dest>'); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| if (!fs.existsSync(src)) { | ||
| console.error(`Source file does not exist: ${src}`); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| const srcStats = fs.statSync(src); | ||
|
|
||
| if (!srcStats.isFile()) { | ||
| console.error(`Source must be a file: ${src}`); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| if (fs.existsSync(dest)) { | ||
| const destStats = fs.statSync(dest); | ||
|
|
||
| if (destStats.isDirectory()) { | ||
| console.error(`Destination cannot be a directory: ${dest}`); | ||
|
|
||
| return; | ||
| } | ||
| } | ||
|
|
||
| if (src === dest) { | ||
| return; | ||
|
Comment on lines
+39
to
+40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Checklist items #2, #7 and #8 require that when source and destination refer to the same file the app must do nothing (no console output). Here you log an error and return. Instead, resolve/normalize both paths (for example with
Comment on lines
+39
to
+40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The raw comparison |
||
| } | ||
|
|
||
| const data = fs.readFileSync(src); | ||
|
|
||
| try { | ||
| fs.writeFileSync(dest, data); | ||
| console.log(`File copied from ${src} to ${dest}`); | ||
| } catch (err) { | ||
| console.error(`Error writing to destination: ${err.message}`); | ||
| } | ||
| }; | ||
|
|
||
| copy(); | ||
|
|
||
| module.exports = { | ||
| copy, | ||
| }; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To compare resolved paths correctly and handle symlinks, also require
path(e.g.const path = require('path')) and usefs.realpathSyncon the source and, if the destination exists, on the destination too. If the destination does not exist usepath.resolve(dest)rather than realpath (realpathSync throws for non-existent paths).