Skip to content

add task solution#4170

Open
RomaPleshenko wants to merge 3 commits into
mate-academy:masterfrom
RomaPleshenko:develop
Open

add task solution#4170
RomaPleshenko wants to merge 3 commits into
mate-academy:masterfrom
RomaPleshenko:develop

Conversation

@RomaPleshenko

Copy link
Copy Markdown
  • DEMO LINK
  • Keyframes implemented using from/to + transform with rotate property
  • Stopwatch is centered and has the correct arrows size
  • All Typical Mistakes from the BEM lesson theory are checked.
  • [-] Code follows all the Code Style Rules ❗️

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because there is a critical BEM modifier naming mismatch that breaks the required speed-up behavior. In src/styles/index.scss you correctly define the modifier as .stopwatch--speed-up via &--speed-up, but in src/index.html you use class="stopwatch stopwatch--speed--up", which creates a different class name, so the speed‑up styles never apply and the requirement to create a modifier called speed-up is not actually met [CHECKLIST ITEM #3]. To fix this, update the HTML to use stopwatch stopwatch--speed-up (single -- before speed-up) so it matches the SCSS selector, or adjust the SCSS modifier to match the exact HTML class name.

Functionally and visually, your stopwatch implementation is very strong: sizes, colors, centering, and animation timings all match the task, and the speed‑up durations in SCSS are correct. As a minor improvement, you could explicitly set transform: rotate(0deg) on the hands outside the keyframes to make the initial top position clearer, but this is not blocking. Once you align the modifier class name, the speed‑up mode will work and the task requirements will be fully satisfied. Keep up the good work—this is a small but important fix to get everything passing.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/index.html Outdated
</head>
<body>
<h1>Stop watch</h1>
<div class="stopwatch stopwatch--speed--up">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class stopwatch--speed--up does not match your BEM modifier .stopwatch--speed-up defined in SCSS. This breaks the required speed-up modifier behavior and violates the description requirement to create a modifier called speed-up. Align the class name (e.g. use stopwatch stopwatch--speed-up).

Comment thread src/styles/index.scss
box-sizing: border-box;

&__hand-minute,
&__hand-second {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stopwatch block’s modifier class is written as stopwatch--speed--up, but in your SCSS you define &--speed-up; this mismatch means the modifier styles are never applied and violates the requirement to "create a BEM modifier called speed-up" and [CHECKLIST ITEM #3] about typical BEM mistakes. Rename this class to stopwatch--speed-up to match the SCSS and proper BEM syntax.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved because it fully meets the functional and checklist requirements for the stopwatch task. The stopwatch is correctly centered, has the specified 80vmin circular dotted border, and the minute and second hands match the required sizes, colors, and starting position at the top. Both hands are animated purely with CSS keyframes using from/to and transform: rotate(...), the second hand completes a full turn in 60s with linear timing, and the minute hand uses steps(60) over 3600s as required. The stopwatch--speed-up BEM modifier is correctly implemented and applied, shortening the second hand to 10s and the minute hand to 600s without breaking the base behavior. Visual test failures are due to small, environment-related pixel differences rather than broken functionality, so they are not blockers. Overall, your implementation is clean, respects BEM naming in this context, and satisfies the task’s core constraints and behavior. Great work aligning your code so closely with the specification and the previous review feedback.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved — the stopwatch behaves and looks as required: it’s centered, the size and colors match the specification, the minute and second hands start from the top, and both animations use only CSS with correct durations and keyframes (from/to with transform: rotate(...)) per [CHECKLIST ITEM #1] and [CHECKLIST ITEM #2]. The stopwatch--speed-up modifier is implemented correctly: base timings are 60s/3600s, and the modifier cleanly overrides them to 10s/600s without breaking the default behavior, which shows good understanding of BEM and modifiers.

This is an educational override to help you progress: visually, BackstopJS reported small pixel mismatches, but these are most likely due to rendering nuances rather than functional issues; if you want to polish it further, you can regenerate reference screenshots or slightly adjust the misMatchThreshold in the visual tests. The main area to improve next time is code style completeness ([CHECKLIST ITEM #4]): go through Mate Academy’s code style rules (naming, formatting, and structure) and double-check that every rule is followed, even if the task itself works perfectly. Overall, your structure, BEM usage, and animation logic look solid — nice work, and keep building on this level of attention to detail.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@RomaPleshenko

Copy link
Copy Markdown
Author
  • DEMO LINK
  • Keyframes implemented using from/to + transform with rotate property
  • Stopwatch is centered and has the correct arrows size
  • All Typical Mistakes from the BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local run is successful. Something went wrong with deploy:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants