Skip to content

Develop#764

Open
AngelaStrechen wants to merge 5 commits into
mate-academy:masterfrom
AngelaStrechen:develop
Open

Develop#764
AngelaStrechen wants to merge 5 commits into
mate-academy:masterfrom
AngelaStrechen:develop

Conversation

@AngelaStrechen

Copy link
Copy Markdown

@brespect brespect left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, but I can't open side menu using burger icon button

@AngelaStrechen AngelaStrechen requested a review from brespect June 5, 2026 13:26

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job!

A few things to improve:

  1. It's better to disable scrolling when menu is open
Image
  1. I would recommend to add cursor: pointer by hover on all interactive elements
Image

@etojeDenys etojeDenys left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, last fix

  1. it would be better if your menu covered the whole page (100 vh)
Image

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants