Skip to content

add task solution#6298

Open
Pavlo-Kurchak wants to merge 1 commit into
mate-academy:masterfrom
Pavlo-Kurchak:develop
Open

add task solution#6298
Pavlo-Kurchak wants to merge 1 commit into
mate-academy:masterfrom
Pavlo-Kurchak:develop

Conversation

@Pavlo-Kurchak

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because a few explicit requirements and checklist items are still not met, and these can affect automated tests and spec compliance. Specifically, you must remove all legacy data-qa="hover" attributes from the non‑first BUY buttons in src/index.html (e.g., the buttons around lines where other cards are defined) so that only data-qa="nav-hover" on the 4th nav link, data-qa="card" on the first card, and data-qa="card-hover" on the first Buy link remain [CHECKLIST ITEM #1]. In addition, the cards container (main with the catalog grid, styled via .conteiner/.container in src/styles/block/container.scss and related files) must have full paddings of 50px vertically and 40px horizontally (e.g., padding: 50px 40px;), not just padding-top: 50px;, to match the description. You also need to ensure that all hover state changes on the card button and title, including background-color and text color, are covered by a smooth 0.3s transition so that no property snaps on hover [CHECKLIST ITEM #5]. As minor but recommended improvements, consider fixing the class name typo from .conteiner to .container, importing vars.scss before other blocks in index.scss, and extracting repeated colors like #fff and #f3f3f3 into variables [CHECKLIST ITEM #2]. Overall, the structure, grid layout, and most hover behaviors look good; once you address these issues, your solution will fully align with the task requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/index.html
<a
href="#"
class="card__button"
data-qa="hover"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates the requirement: remove old data-qa attributes. You should remove data-qa="hover" from non-testing buttons; only the first card’s Buy link should have data-qa="card-hover" according to the description.

Comment thread src/index.html
<a
href="#"
class="card__button"
data-qa="hover"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: keeping data-qa="hover" here conflicts with the requirement to remove old data-qa attributes while only using the specified testing attributes.

Comment thread src/index.html
<a
href="#"
class="card__button"
data-qa="hover"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well, data-qa="hover" should be removed from this button; only the first card needs the special data-qa="card-hover" attribute for tests.

Comment thread src/index.html
<a
href="#"
class="card__button"
data-qa="hover"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This button still has data-qa="hover", which violates the description point remove old data-qa attributes. Consider removing it.

Comment thread src/index.html
<a
href="#"
class="card__button"
data-qa="hover"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue: data-qa="hover" on this button should be removed to comply with the requirement about old data-qa attributes.

@@ -0,0 +1,20 @@
.stars {
display: flex;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class name .conteiner is a typo and doesn’t match common naming conventions; while not explicitly forbidden, it may violate the general code style rule (checklist item: "Code follows all the Code Style Rules"). Consider renaming this class to .container in both HTML and SCSS.

Comment on lines +1 to +3
$font-main: 'Roboto', sans-serif;
$color-text-main: #060b35;
$color-text-second: #616070;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This .page block is currently unused in your HTML (no element has class="page"). While not breaking anything, it introduces dead code; consider either applying this class to a top-level container (like body or a wrapper div) or removing the unused block to keep styles clean.

Comment on lines +1 to +5
$font-main: 'Roboto', sans-serif;
$color-text-main: #060b35;
$color-text-second: #616070;
$color-button: #00acdc;
$card-width: 200px;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist item #2 says: "Repeated sizes and special colors are put to variables". Here you define some colors and the card width, but other repeated colors like #fff and #f3f3f3 used in other SCSS files (e.g., card.scss) are not extracted into variables, which partially violates that checklist item.

Comment on lines +1 to +3
$font-main: 'Roboto', sans-serif;
$color-text-main: #060b35;
$color-text-second: #616070;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To satisfy the code style and dependency rules, vars should be imported before any blocks that depend on its variables. Currently @import 'block/header'; and @import 'block/container'; come before @import 'block/vars';. Reordering so that vars is imported first will prevent potential variable-undefined issues and better align with "Code follows all the Code Style Rules".

Comment thread src/styles/index.scss
Comment on lines +1 to +3
@import 'block/header';
@import 'block/container';
@import 'block/vars';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since block files like header, container, page, stars, and card rely on variables from vars.scss, it’s better (and more in line with typical SCSS structure) to import vars before these blocks to avoid potential undefined-variable issues. Consider moving @import 'block/vars'; to the top.

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong with deploy, but all tests are passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants