Skip to content

add task solution #6289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diiyavol wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add task solution #6289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8db55b
add task solution
diiyavol Jun 28, 2026
17201ba
add task solution2
diiyavol Jun 28, 2026
5752525
add task solution3
diiyavol Jun 28, 2026
d37fa96
add task solution4
diiyavol Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
323 changes: 321 additions & 2 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,327 @@
href="styles/index.scss"
/>
</head>

<body>
<h1>Catalog</h1>
<header class="header">
<a
href="#"
class="header__logo-link"
>
<img
src="images/logo.png"
alt="logo"

@mateacademy-ai-mentor mateacademy-ai-mentor Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: "Repeated sizes and special colors are put to variables". The border color #f3f3f3 is a special color reused in the header and cards, so it should be extracted to variables.scss and used via a variable.

class="header__logo-img"
/>
</a>

<nav class="header__nav menu">
<ul class="menu__list">
<li class="menu__item">
<a
href="#"
class="menu__link is-active"
>
apple
</a>
</li>
<li class="menu__item">
<a
href="#"
class="menu__link"
>
samsung
</a>
</li>
<li class="menu__item">
<a
href="#"
class="menu__link"
>
smartphones
</a>
</li>
<li class="menu__item">
<a
href="#"
class="menu__link"
data-qa="nav-hover"
>
laptops & computers
</a>
</li>
<li class="menu__item">
<a
Comment on lines +70 to +72

@mateacademy-ai-mentor mateacademy-ai-mentor Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #5: "All changes on :hover are smooth". The card title color changes on hover but .card__title does not have a transition property, so the color change is instantaneous rather than smooth over 300ms. Add a transition: color 300ms; (or similar) to &__title to make this hover change smooth.

href="#"
class="menu__link"
>
gadgets
</a>

@mateacademy-ai-mentor mateacademy-ai-mentor Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #5: "All changes on :hover are smooth" and the description requirement "Make all the changes smooth on hover (during 300ms)". The menu links use transition: color 0.2s ease; which is 200ms, not 300ms. Update this transition to 300ms, and ensure it covers the color change on hover.

</li>
<li class="menu__item">
<a
href="#"
class="menu__link"
>
tablets
</a>
</li>
<li class="menu__item">
<a
href="#"
class="menu__link"
>
photo
</a>
</li>
<li class="menu__item">
<a
href="#"
class="menu__link"
>
video
</a>
</li>
</ul>
</nav>
</header>
<main>
<div
class="card"
data-qa="card"
Comment on lines +91 to +109

@mateacademy-ai-mentor mateacademy-ai-mentor Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #5: "All changes on :hover are smooth". The button hover changes (text color, background color, border) do not have an explicit transition defined, so they will change instantly. Add a transition (e.g. transition: color 300ms, background-color 300ms, border-color 300ms;) to &__button to make all hover changes smooth over 300ms.

>
<div class="card__image"></div>
<div class="card__info">
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
</div>
<div class="card__rating rating">
<div class="rating__stars rating__stars--4">
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__reviews">Reviews: 5</div>
</div>
</div>
<div class="card__price">
<div class="card__price-label">Price:</div>
<div class="card__price-value">$2,199</div>
</div>
<a
href="#"
class="card__button"
data-qa="card-hover"
>
buy
</a>
</div>

<div class="card">
<div class="card__image"></div>
<div class="card__info">
<div class="card__title">

@mateacademy-ai-mentor mateacademy-ai-mentor Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: "Repeated sizes and special colors are put to variables". The card title hover color #34568b is a special color and should be moved into variables.scss and referenced as a variable here.

APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
</div>
<div class="card__rating rating">
<div class="rating__stars rating__stars--4">
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
</div>
<div class="rating__reviews">Reviews: 5</div>
</div>
<div class="card__price">
<div class="card__price-label">Price:</div>
<div class="card__price-value">$2,199</div>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
<div class="card">
<div class="card__image"></div>
<div class="card__info">
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
</div>
<div class="card__rating rating">
<div class="rating__stars rating__stars--4">
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__reviews">Reviews: 5</div>
</div>
</div>
<div class="card__price">
<div class="card__price-label">Price:</div>
<div class="card__price-value">$2,199</div>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
<div class="card">
<div class="card__image"></div>
<div class="card__info">
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
</div>
<div class="card__rating rating">
<div class="rating__stars rating__stars--4">
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__reviews">Reviews: 5</div>
</div>
</div>
<div class="card__price">
<div class="card__price-label">Price:</div>
<div class="card__price-value">$2,199</div>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
<div class="card">
<div class="card__image"></div>
<div class="card__info">
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
</div>
<div class="card__rating rating">
<div class="rating__stars rating__stars--4">
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__reviews">Reviews: 5</div>
</div>
</div>
<div class="card__price">
<div class="card__price-label">Price:</div>
<div class="card__price-value">$2,199</div>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
<div class="card">
<div class="card__image"></div>
<div class="card__info">
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
</div>
<div class="card__rating rating">
<div class="rating__stars rating__stars--4">
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__reviews">Reviews: 5</div>
</div>
</div>
<div class="card__price">
<div class="card__price-label">Price:</div>
<div class="card__price-value">$2,199</div>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
<div class="card">
<div class="card__image"></div>
<div class="card__info">
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
</div>
<div class="card__rating rating">
<div class="rating__stars rating__stars--4">
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
Comment on lines +286 to +300

@mateacademy-ai-mentor mateacademy-ai-mentor Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #5: "All changes on :hover are smooth". The transition is declared inside the &:hover block and not tied to specific properties; move transition: color 300ms, background-color 300ms, border-color 300ms; to the base .card__button rule so the hover changes animate smoothly.

<div class="rating__reviews">Reviews: 5</div>
</div>
</div>
<div class="card__price">
<div class="card__price-label">Price:</div>
<div class="card__price-value">$2,199</div>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
<div class="card">
<div class="card__image"></div>
<div class="card__info">
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<div class="card__code">Product code: 195434</div>
</div>
<div class="card__rating rating">
<div class="rating__stars rating__stars--4">
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__star"></div>
<div class="rating__reviews">Reviews: 5</div>
</div>
</div>
<div class="card__price">
<div class="card__price-label">Price:</div>
<div class="card__price-value">$2,199</div>
</div>
<a
href="#"
class="card__button"
>
buy
</a>
</div>
</main>
</body>
</html>
Loading
Loading