Skip to content

add task solution#5467

Open
AlexFromUkraine wants to merge 2 commits into
mate-academy:masterfrom
AlexFromUkraine:develop
Open

add task solution#5467
AlexFromUkraine wants to merge 2 commits into
mate-academy:masterfrom
AlexFromUkraine:develop

Conversation

@AlexFromUkraine

Copy link
Copy Markdown
  • DEMO LINK

  • TEST REPORT LINK

  • Changing 'month-lengh' and 'start-day' modifier in the code element
    reflects in changing calendar layout

  • Each day has no modifiers, only class (eg. calendar__day)

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the [Code Style Rules ❗️]

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because there are still two critical mismatches with the task requirements. First, the calendar is only centered horizontally; the requirement clearly states it must be in the middle of the screen both horizontally and vertically, and right now body/html (or the main container) are not set up to vertically center the .calendar (e.g., via align-items: center plus full-height flex). Second, the styles are implemented in src/styles/index.scss, but the task explicitly requires using src/styles/main.scss, so the file should be renamed or moved and the <link> in src/index.html updated accordingly.

To fix this, adjust your layout so the main container that wraps the calendar (such as .page or body) is a full-height flex container with both justify-content: center and align-items: center, or an equivalent approach that truly centers the calendar vertically. Then rename index.scss to main.scss (keeping the same content) and change the HTML to reference styles/main.scss so it aligns with the specification. Aside from these issues, your implementation of the calendar structure, SCSS loops, BEM naming, and hover behavior looks solid, so once you address these two blockers, it should fully meet the requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/styles/index.scss Outdated
Comment on lines +18 to +21
.page {
display: flex;
justify-content: center;
height: 100vh;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The calendar is centered horizontally but not vertically; this doesn't fully satisfy the requirement to "Display a calendar in the middle of the screen (both horizontally and vertically)". Consider adding vertical centering (e.g., align-items: center here, or using a flex layout on body/html) so the calendar is centered both ways.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved because it fully meets the functional and checklist requirements for this task. The calendar is correctly centered on the page, uses the required BEM structure, and is implemented purely with HTML and SCSS without JavaScript. You’ve implemented start-day and month-length modifiers so that changing them in the HTML properly shifts the first day and shows the correct number of days, satisfying [CHECKLIST ITEM #1]. Day numbers are generated via CSS ::before and SCSS loops, each day cell is a 100px grey square with a 1px black border, and the flex layout with gaps and computed width uses shared SCSS variables instead of repeated hardcoded values. Hover behavior (pointer cursor, pink background #FFBFCB, 20px upward transform, 0.5s transition) works exactly as specified. A minor non-blocking improvement would be to remove any unused style files (like an unused index.scss) to avoid confusion, but this is not required for passing the task. Overall, this is a clean, correct implementation—well done.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants