Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 34 additions & 2 deletions src/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,42 @@
<title>Calendar</title>
<link
rel="stylesheet"
href="styles/index.scss"
href="../src/styles/main.scss"
/>
</head>
<body>
<h1>Calendar</h1>
<div class="calendar calendar--month-length-31 calendar--start-day-sun">
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
<div class="calendar__day"></div>
</div>
</body>
</html>
55 changes: 55 additions & 0 deletions src/styles/calendar.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
.calendar {
width: 7 * $widthDay + 6 * $gapDay + 2 * $paddingCalendar;
padding: $paddingCalendar;
display: flex;
flex-flow: row wrap;
gap: $gapDay;

&__day {
position: relative;
width: $widthDay;
height: $heightDay;
border: 1px solid black;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description requires: "Write styles in src/styles/main.scss instead of src/style.css". Currently you use styles/index.scss as the main stylesheet and link to it here. This violates that requirement; consider renaming your entry SCSS file to main.scss and updating this href accordingly.

box-sizing: border-box;
background-color: #eee;
cursor: pointer;
transition: all 0.5s ease;

&::before {
position: absolute;
inset: 0;
font-size: 30px;

display: flex;
align-items: center;
justify-content: center;
}

&:hover {
background-color: #ffbfcb;
transform: translate(0, -20px);
}

@for $monthDay from 1 through 31 {
&:nth-child(#{$monthDay}) {
&::before {
content: '#{$monthDay}';
}
}
}
}

@for $monthLength from 28 through 31 {
&--month-length-#{$monthLength} {
.calendar__day:nth-child(n + #{$monthLength + 1}) {
display: none;
}
}
}

@each $day, $marginLeft in $daysWeek {
&--start-day-#{$day} &__day:first-child {
margin-left: $marginLeft;
}
}
}
3 changes: 0 additions & 3 deletions src/styles/index.scss

This file was deleted.

16 changes: 16 additions & 0 deletions src/styles/main.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
@import './variables';
@import './calendar';

* {
margin: 0;
padding: 0;
box-sizing: border-box;
}

body {
min-height: 100vh;
font-family: Arial, Helvetica, sans-serif;
display: flex;
align-items: center;
justify-content: center;
}
14 changes: 14 additions & 0 deletions src/styles/variables.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
$widthDay: 100px;
$heightDay: $widthDay;
$paddingCalendar: 10px;
$gapDay: 1px;
Comment on lines +2 to +4

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates the requirement: "Use flex with 1px gap and limit its width to exactly 7 columns + 10px paddings" and "Don't use hardcoded px values if they are used several times". The width is calculated as width: $widthDay * 7 + $gapDay * 6; but does not include the 10px paddings, and padding: 10px; uses a repeated hardcoded value. Consider introducing a padding variable (e.g. $calendarPadding) and including it in the width calculation so the total width matches 7 day columns + left+right padding, while avoiding repeated literal 10px values.

$gap-day-width: $widthDay + $gapDay;
$daysWeek: (
'mon': 0,
'tue': $gap-day-width,
'wed': $gap-day-width * 2,
'thu': $gap-day-width * 3,
'fri': $gap-day-width * 4,
'sat': $gap-day-width * 5,
'sun': $gap-day-width * 6,
);
Loading