add task solution#2530
Open
netzelnatalia wants to merge 5 commits into
Open
Conversation
nazarmatsevych
suggested changes
Nov 3, 2023
nazarmatsevych
left a comment
nazarmatsevych
left a comment
There was a problem hiding this comment.
Almost done, let's make a little improvements
Comment on lines
+64
to
+71
| goBack(steps = 1) { | ||
| if (steps > 0) { | ||
| this.coords.y -= steps; | ||
| } | ||
|
|
||
| return this; | ||
| }, | ||
| goRight(steps = 1) { |
There was a problem hiding this comment.
Suggested change
| goBack(steps = 1) { | |
| if (steps > 0) { | |
| this.coords.y -= steps; | |
| } | |
| return this; | |
| }, | |
| goRight(steps = 1) { | |
| goBack(steps = 1) { | |
| if (steps > 0) { | |
| this.coords.y -= steps; | |
| } | |
| return this; | |
| }, | |
| goRight(steps = 1) { |
Add empty line between methods
| }, | ||
| get info() { | ||
| const robotName = `name: ${this.name}, `; | ||
| const robotInfo = `chip version: ${this.version}, wheels: ${this.wheels}`; |
There was a problem hiding this comment.
Or you can use concatenation instead
| this.coords.x = 1400; | ||
| this.coords.y = 500; | ||
|
|
||
| return this; |
There was a problem hiding this comment.
You are not going to call this method in the chain, so no need to return this here
nazarmatsevych
approved these changes
Nov 4, 2023
Comment on lines
+49
to
+63
| get info() { | ||
| return 'name: ' + this.name + ', chip version: ' | ||
| + this.version + ', wheels: ' + this.wheels; | ||
| }, | ||
| get location() { | ||
| return this.name + ': x=' + this.coords.x + ', y=' + this.coords.y; | ||
| }, | ||
| goForward(steps = 1) { | ||
| if (steps > 0) { | ||
| this.coords.y += steps; | ||
| } | ||
|
|
||
| return this; | ||
| }, | ||
| goBack(steps = 1) { |
There was a problem hiding this comment.
Suggested change
| get info() { | |
| return 'name: ' + this.name + ', chip version: ' | |
| + this.version + ', wheels: ' + this.wheels; | |
| }, | |
| get location() { | |
| return this.name + ': x=' + this.coords.x + ', y=' + this.coords.y; | |
| }, | |
| goForward(steps = 1) { | |
| if (steps > 0) { | |
| this.coords.y += steps; | |
| } | |
| return this; | |
| }, | |
| goBack(steps = 1) { | |
| get info() { | |
| return 'name: ' + this.name + ', chip version: ' | |
| + this.version + ', wheels: ' + this.wheels; | |
| }, | |
| get location() { | |
| return this.name + ': x=' + this.coords.x + ', y=' + this.coords.y; | |
| }, | |
| goForward(steps = 1) { | |
| if (steps > 0) { | |
| this.coords.y += steps; | |
| } | |
| return this; | |
| }, | |
| goBack(steps = 1) { |
Add empty line between all your methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.