Solution#1843
Conversation
Sofiia912
commented
Jul 3, 2026
- DEMO LINK
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because there are two critical requirement violations that affect the task’s correctness and constraints. First, in src/scripts/main.js you define a hardcoded people array (around the top of the file) instead of using the people data imported from people.json, which breaks the requirement that the table must be generated from the JSON file [CHECKLIST ITEM #6]; this could cause tests that rely on the import to fail. To fix this, remove the local const people = [...] definition and rely only on the already-imported people variable, keeping your loop and calculations unchanged.
Second, the task specifies that only main.js should be modified, but you also changed README.md [CHECKLIST ITEM #5], which violates the file-change constraint; you should revert any README changes back to the original state provided by the assignment. As a minor improvement, you can safely remove console.log(people); once you’re done debugging to avoid unnecessary console noise. Your table-building logic (creating rows, computing age as died - born, computing century with Math.ceil(died / 100), and appending to .dashboard) is solid, so once you fix the data source and revert the extra file changes, your solution will fully meet the requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I’m requesting changes because there is still one critical requirement not met: the assignment explicitly says that only src/scripts/main.js should be modified, but your PR also changes README.md. Even though your dashboard implementation is correct (you use the imported people array, render the 6 columns in the right order, and compute age and century properly), the extra README modifications violate the “change only main.js” constraint and must be fixed before this can be considered complete.
To fix this, revert README.md to its original state from the starter project so that the only code change in the PR is in src/scripts/main.js. After reverting, double‑check that the table still renders correctly and that no functionality was lost in the process. Functionality-wise, you’ve done a good job meeting the core requirements; once the README change is undone, your solution should be ready to pass. Keep up the solid work—this is very close to being fully accepted.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.