Skip to content

add task solution#1840

Open
PrimaSB wants to merge 1 commit into
mate-academy:masterfrom
PrimaSB:develop
Open

add task solution#1840
PrimaSB wants to merge 1 commit into
mate-academy:masterfrom
PrimaSB:develop

Conversation

@PrimaSB

@PrimaSB PrimaSB commented Jun 30, 2026

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because there are a couple of core requirement violations that affect the task’s correctness, even though your table-generation logic itself looks solid. The task explicitly requires using the already imported people.json data, but in src/scripts/main.js you define a separate const people = [...] array instead; this duplicates the data and ignores the required import, so you should remove the local array and rely solely on the imported people object [CHECKLIST ITEM #2, #11]. The instructions also state that only main.js should be modified, but you changed the README/description as well, so those non-code changes need to be reverted to match the task constraints [CHECKLIST ITEM #10]. In addition, tests are likely expecting the raw gender values ('m' / 'f'), while you convert them to 'Male' / 'Female', which can cause mismatched output; adjust the cell content to use the original person.sex value [CHECKLIST ITEM #7]. Once you fix the data source usage, revert the README change, and align the gender output with the expected format, your implementation should fully meet the requirements and can be approved. Overall, your DOM manipulation, age and century calculations are nicely done, so these changes are mostly about adhering strictly to the specification.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@etojeDenys etojeDenys left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants