add task solution

[FS-Olexander]

No description provided.

[mateacademy-ai-mentor]

Review Summary

I am requesting changes because one core requirement of the task is not followed and this affects how the project is supposed to work with its tooling. Functionally, your table generation in src/scripts/main.js is solid: you correctly select the .dashboard table, create one <tr> per person with 6 <td> cells (name, gender, born, died, age, century), and compute age and century correctly. However, instead of using the people array imported from people.json as required, you’ve inlined a full const people = [...] definition in main.js, which violates the requirement to rely on the provided JSON data source [CHECKLIST ITEM #6]. This can break the expected bundling/tests that assume the imported people variable exists and is used.

The critical fixes you need:

• Data source: Remove the locally hardcoded const people = [...] from main.js and use only the already imported people array from people.json (your table-building logic can stay the same, just iterate over the imported people).
• Files changed: Revert any changes you made to .github/workflows/test.yml-template and README.md so that only main.js is modified as the task requires [CHECKLIST ITEM #5].
• Demo link: In README.md (or wherever the demo link lives), replace the <your_account> placeholder with your actual GitHub username so the demo URL points to your real GitHub Pages deployment [CHECKLIST ITEM #1].

Once you rely on the imported JSON data and revert the extra file changes, your solution should fully align with the task requirements. Your DOM manipulation and calculations are on the right track; you just need to hook them into the prescribed project structure.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

Review Summary

I am requesting changes because there is still a critical blocker preventing the task from being fully completed and the checks from passing. Functionally, your src/scripts/main.js is in great shape: it correctly imports people from people.json, generates one <tr> with 6 <td> cells per person (name, gender, born, died, age, century), computes age as died - born, and century as Math.ceil(died / 100), and appends rows to the .dashboard table as required. However, the build currently fails with a Parcel error at src/scripts/main.js:2 saying Browser scripts cannot have imports or exports, which means the app cannot be bundled and tests cannot run. This is caused by using import in a script that Parcel treats as a non-module; you need to fix the setup so that Parcel recognizes it as a module (for example, by ensuring the HTML uses <script type="module" src="scripts/main.js"></script> or by aligning with the project’s prescribed configuration). In addition, the task explicitly requires changing only main.js, but your PR still includes modifications to .github/workflows/test.yml-template and possibly README.md, which must be reverted to their original state. Once you resolve the Parcel configuration/import issue and revert all unrelated file changes, your solution should satisfy both the functional and technical requirements. Your core implementation is strong; these last adjustments are mainly about tooling and project rules, and fixing them will complete the task cleanly.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

Review Summary

I am approving your solution as an educational override so you can keep progressing while learning, even though there is still a build-related issue. You did a solid job in main.js: you correctly iterate over the people array, create a <tr> per person with 6 <td> cells, and compute both age (died - born) and century (Math.ceil(died / 100)), satisfying the core functional requirements [CHECKLIST ITEM #1–5, #7–5]. The main technical problem is that main.js currently uses require('../api/people.json') at the top (around line 3), but Parcel in this setup expects either ES module syntax with type="module" in the HTML or no module syntax at all, which is why the build fails. To improve this, you can switch back to import people from '../api/people.json' and ensure the script tag in index.html uses type="module", or alternatively load the JSON via fetch and work with the data inside the callback. Also, remember that the original task asked you to change only src/scripts/main.js, so any edits to files like .github/workflows/test.yml-template or README.md should be reverted to stay within the constraints [CHECKLIST ITEM #6, #15]. Overall, your core logic is strong and shows good understanding of DOM manipulation and basic data transformation—fixing the module loading and extra file changes will bring your solution fully in line with the project requirements.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩