-
Notifications
You must be signed in to change notification settings - Fork 1.7k
add solution #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
m-berezovskyy
wants to merge
2
commits into
mate-academy:master
Choose a base branch
from
m-berezovskyy:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add solution #1833
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,360 +1,27 @@ | ||
| 'use strict'; | ||
|
|
||
| const people = [ | ||
| { | ||
| name: 'Carolus Haverbeke', | ||
| sex: 'm', | ||
| born: 1832, | ||
| died: 1905, | ||
| fatherName: 'Carel Haverbeke', | ||
| motherName: 'Maria van Brussel', | ||
| slug: 'carolus-haverbeke-1832', | ||
| }, | ||
| { | ||
| name: 'Emma de Milliano', | ||
| sex: 'f', | ||
| born: 1876, | ||
| died: 1956, | ||
| fatherName: 'Petrus de Milliano', | ||
| motherName: 'Sophia van Damme', | ||
| slug: 'emma-de-milliano-1876', | ||
| }, | ||
| { | ||
| name: 'Maria de Rycke', | ||
| sex: 'f', | ||
| born: 1683, | ||
| died: 1724, | ||
| fatherName: 'Frederik de Rycke', | ||
| motherName: 'Laurentia van Vlaenderen', | ||
| slug: 'maria-de-rycke-1683', | ||
| }, | ||
| { | ||
| name: 'Jan van Brussel', | ||
| sex: 'm', | ||
| born: 1714, | ||
| died: 1748, | ||
| fatherName: 'Jacobus van Brussel', | ||
| motherName: 'Joanna van Rooten', | ||
| slug: 'jan-van-brussel-1714', | ||
| }, | ||
| { | ||
| name: 'Philibert Haverbeke', | ||
| sex: 'm', | ||
| born: 1907, | ||
| died: 1997, | ||
| fatherName: 'Emile Haverbeke', | ||
| motherName: 'Emma de Milliano', | ||
| slug: 'philibert-haverbeke-1907', | ||
| }, | ||
| { | ||
| name: 'Jan Frans van Brussel', | ||
| sex: 'm', | ||
| born: 1761, | ||
| died: 1833, | ||
| fatherName: 'Jacobus Bernardus van Brussel', | ||
| motherName: null, | ||
| slug: 'jan-frans-van-brussel-1761', | ||
| }, | ||
| { | ||
| name: 'Pauwels van Haverbeke', | ||
| sex: 'm', | ||
| born: 1535, | ||
| died: 1582, | ||
| fatherName: 'N. van Haverbeke', | ||
| motherName: null, | ||
| slug: 'pauwels-van-haverbeke-1535', | ||
| }, | ||
| { | ||
| name: 'Clara Aernoudts', | ||
| sex: 'f', | ||
| born: 1918, | ||
| died: 2012, | ||
| fatherName: 'Henry Aernoudts', | ||
| motherName: 'Sidonie Coene', | ||
| slug: 'clara-aernoudts-1918', | ||
| }, | ||
| { | ||
| name: 'Emile Haverbeke', | ||
| sex: 'm', | ||
| born: 1877, | ||
| died: 1968, | ||
| fatherName: 'Carolus Haverbeke', | ||
| motherName: 'Maria Sturm', | ||
| slug: 'emile-haverbeke-1877', | ||
| }, | ||
| { | ||
| name: 'Lieven de Causmaecker', | ||
| sex: 'm', | ||
| born: 1696, | ||
| died: 1724, | ||
| fatherName: 'Carel de Causmaecker', | ||
| motherName: 'Joanna Claes', | ||
| slug: 'lieven-de-causmaecker-1696', | ||
| }, | ||
| { | ||
| name: 'Pieter Haverbeke', | ||
| sex: 'm', | ||
| born: 1602, | ||
| died: 1642, | ||
| fatherName: 'Lieven van Haverbeke', | ||
| motherName: null, | ||
| slug: 'pieter-haverbeke-1602', | ||
| }, | ||
| { | ||
| name: 'Livina Haverbeke', | ||
| sex: 'f', | ||
| born: 1692, | ||
| died: 1743, | ||
| fatherName: 'Daniel Haverbeke', | ||
| motherName: 'Joanna de Pape', | ||
| slug: 'livina-haverbeke-1692', | ||
| }, | ||
| { | ||
| name: 'Pieter Bernard Haverbeke', | ||
| sex: 'm', | ||
| born: 1695, | ||
| died: 1762, | ||
| fatherName: 'Willem Haverbeke', | ||
| motherName: 'Petronella Wauters', | ||
| slug: 'pieter-bernard-haverbeke-1695', | ||
| }, | ||
| { | ||
| name: 'Lieven van Haverbeke', | ||
| sex: 'm', | ||
| born: 1570, | ||
| died: 1636, | ||
| fatherName: 'Pauwels van Haverbeke', | ||
| motherName: 'Lievijne Jans', | ||
| slug: 'lieven-van-haverbeke-1570', | ||
| }, | ||
| { | ||
| name: 'Joanna de Causmaecker', | ||
| sex: 'f', | ||
| born: 1762, | ||
| died: 1807, | ||
| fatherName: 'Bernardus de Causmaecker', | ||
| motherName: null, | ||
| slug: 'joanna-de-causmaecker-1762', | ||
| }, | ||
| { | ||
| name: 'Willem Haverbeke', | ||
| sex: 'm', | ||
| born: 1668, | ||
| died: 1731, | ||
| fatherName: 'Lieven Haverbeke', | ||
| motherName: 'Elisabeth Hercke', | ||
| slug: 'willem-haverbeke-1668', | ||
| }, | ||
| { | ||
| name: 'Pieter Antone Haverbeke', | ||
| sex: 'm', | ||
| born: 1753, | ||
| died: 1798, | ||
| fatherName: 'Jan Francies Haverbeke', | ||
| motherName: 'Petronella de Decker', | ||
| slug: 'pieter-antone-haverbeke-1753', | ||
| }, | ||
| { | ||
| name: 'Maria van Brussel', | ||
| sex: 'f', | ||
| born: 1801, | ||
| died: 1834, | ||
| fatherName: 'Jan Frans van Brussel', | ||
| motherName: 'Joanna de Causmaecker', | ||
| slug: 'maria-van-brussel-1801', | ||
| }, | ||
| { | ||
| name: 'Angela Haverbeke', | ||
| sex: 'f', | ||
| born: 1728, | ||
| died: 1734, | ||
| fatherName: 'Pieter Bernard Haverbeke', | ||
| motherName: 'Livina de Vrieze', | ||
| slug: 'angela-haverbeke-1728', | ||
| }, | ||
| { | ||
| name: 'Elisabeth Haverbeke', | ||
| sex: 'f', | ||
| born: 1711, | ||
| died: 1754, | ||
| fatherName: 'Jan Haverbeke', | ||
| motherName: 'Maria de Rycke', | ||
| slug: 'elisabeth-haverbeke-1711', | ||
| }, | ||
| { | ||
| name: 'Lievijne Jans', | ||
| sex: 'f', | ||
| born: 1542, | ||
| died: 1582, | ||
| fatherName: null, | ||
| motherName: null, | ||
| slug: 'lievijne-jans-1542', | ||
| }, | ||
| { | ||
| name: 'Bernardus de Causmaecker', | ||
| sex: 'm', | ||
| born: 1721, | ||
| died: 1789, | ||
| fatherName: 'Lieven de Causmaecker', | ||
| motherName: 'Livina Haverbeke', | ||
| slug: 'bernardus-de-causmaecker-1721', | ||
| }, | ||
| { | ||
| name: 'Jacoba Lammens', | ||
| sex: 'f', | ||
| born: 1699, | ||
| died: 1740, | ||
| fatherName: 'Lieven Lammens', | ||
| motherName: 'Livina de Vrieze', | ||
| slug: 'jacoba-lammens-1699', | ||
| }, | ||
| { | ||
| name: 'Pieter de Decker', | ||
| sex: 'm', | ||
| born: 1705, | ||
| died: 1780, | ||
| fatherName: 'Joos de Decker', | ||
| motherName: 'Petronella van de Steene', | ||
| slug: 'pieter-de-decker-1705', | ||
| }, | ||
| { | ||
| name: 'Joanna de Pape', | ||
| sex: 'f', | ||
| born: 1654, | ||
| died: 1723, | ||
| fatherName: 'Vincent de Pape', | ||
| motherName: 'Petronella Wauters', | ||
| slug: 'joanna-de-pape-1654', | ||
| }, | ||
| { | ||
| name: 'Daniel Haverbeke', | ||
| sex: 'm', | ||
| born: 1652, | ||
| died: 1723, | ||
| fatherName: 'Lieven Haverbeke', | ||
| motherName: 'Elisabeth Hercke', | ||
| slug: 'daniel-haverbeke-1652', | ||
| }, | ||
| { | ||
| name: 'Lieven Haverbeke', | ||
| sex: 'm', | ||
| born: 1631, | ||
| died: 1676, | ||
| fatherName: 'Pieter Haverbeke', | ||
| motherName: 'Anna van Hecke', | ||
| slug: 'lieven-haverbeke-1631', | ||
| }, | ||
| { | ||
| name: 'Martina de Pape', | ||
| sex: 'f', | ||
| born: 1666, | ||
| died: 1727, | ||
| fatherName: 'Vincent de Pape', | ||
| motherName: 'Petronella Wauters', | ||
| slug: 'martina-de-pape-1666', | ||
| }, | ||
| { | ||
| name: 'Jan Francies Haverbeke', | ||
| sex: 'm', | ||
| born: 1725, | ||
| died: 1779, | ||
| fatherName: 'Pieter Bernard Haverbeke', | ||
| motherName: 'Livina de Vrieze', | ||
| slug: 'jan-francies-haverbeke-1725', | ||
| }, | ||
| { | ||
| name: 'Maria Haverbeke', | ||
| sex: 'm', | ||
| born: 1905, | ||
| died: 1997, | ||
| fatherName: 'Emile Haverbeke', | ||
| motherName: 'Emma de Milliano', | ||
| slug: 'maria-haverbeke-1905', | ||
| }, | ||
| { | ||
| name: 'Petronella de Decker', | ||
| sex: 'f', | ||
| born: 1731, | ||
| died: 1781, | ||
| fatherName: 'Pieter de Decker', | ||
| motherName: 'Livina Haverbeke', | ||
| slug: 'petronella-de-decker-1731', | ||
| }, | ||
| { | ||
| name: 'Livina Sierens', | ||
| sex: 'f', | ||
| born: 1761, | ||
| died: 1826, | ||
| fatherName: 'Jan Sierens', | ||
| motherName: 'Maria van Waes', | ||
| slug: 'livina-sierens-1761', | ||
| }, | ||
| { | ||
| name: 'Laurentia Haverbeke', | ||
| sex: 'f', | ||
| born: 1710, | ||
| died: 1786, | ||
| fatherName: 'Jan Haverbeke', | ||
| motherName: 'Maria de Rycke', | ||
| slug: 'laurentia-haverbeke-1710', | ||
| }, | ||
| { | ||
| name: 'Carel Haverbeke', | ||
| sex: 'm', | ||
| born: 1796, | ||
| died: 1837, | ||
| fatherName: 'Pieter Antone Haverbeke', | ||
| motherName: 'Livina Sierens', | ||
| slug: 'carel-haverbeke-1796', | ||
| }, | ||
| { | ||
| name: 'Elisabeth Hercke', | ||
| sex: 'f', | ||
| born: 1632, | ||
| died: 1674, | ||
| fatherName: 'Willem Hercke', | ||
| motherName: 'Margriet de Brabander', | ||
| slug: 'elisabeth-hercke-1632', | ||
| }, | ||
| { | ||
| name: 'Jan Haverbeke', | ||
| sex: 'm', | ||
| born: 1671, | ||
| died: 1731, | ||
| fatherName: 'Lieven Haverbeke', | ||
| motherName: 'Elisabeth Hercke', | ||
| slug: 'jan-haverbeke-1671', | ||
| }, | ||
| { | ||
| name: 'Anna van Hecke', | ||
| sex: 'f', | ||
| born: 1607, | ||
| died: 1670, | ||
| fatherName: 'Paschasius van Hecke', | ||
| motherName: 'Martijntken Beelaert', | ||
| slug: 'anna-van-hecke-1607', | ||
| }, | ||
| { | ||
| name: 'Maria Sturm', | ||
| sex: 'f', | ||
| born: 1835, | ||
| died: 1917, | ||
| fatherName: 'Charles Sturm', | ||
| motherName: 'Seraphina Spelier', | ||
| slug: 'maria-sturm-1835', | ||
| }, | ||
| { | ||
| name: 'Jacobus Bernardus van Brussel', | ||
| sex: 'm', | ||
| born: 1736, | ||
| died: 1809, | ||
| fatherName: 'Jan van Brussel', | ||
| motherName: 'Elisabeth Haverbeke', | ||
| slug: 'jacobus-bernardus-van-brussel-1736', | ||
| }, | ||
| ]; | ||
| import people from './people.json'; | ||
|
|
||
| // eslint-disable-next-line no-console | ||
| console.log(people); // you can remove it | ||
| const table = | ||
| document.querySelector('.dashboard tbody') || | ||
| document.querySelector('.dashboard'); | ||
|
|
||
| // write your code here | ||
| for (const person of people) { | ||
| const tr = document.createElement('tr'); | ||
|
|
||
| const gender = person.sex === 'm' ? 'Male' : 'Female'; | ||
|
|
||
| const age = person.died - person.born; | ||
| const century = Math.ceil(person.died / 100); | ||
|
|
||
| tr.innerHTML = ` | ||
| <td>${person.name}</td> | ||
| <td>${gender}</td> | ||
| <td>${person.born}</td> | ||
| <td>${person.died}</td> | ||
| <td>${age}</td> | ||
| <td>${century}</td> | ||
| `; | ||
|
|
||
| table.appendChild(tr); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall table-generation logic (querying the
.dashboardtable, looping overpeople, computingageandcentury, and appending rows) is correct, but keep in mind it must work with the importedpeoplevariable once you remove the local hardcoded array above.