add task solution#1832
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am approving your solution because it correctly implements all core functional requirements of the task. You use the people array as the data source, create a <tr> for each person, and generate exactly six <td> cells with name, converted gender, born, died, computed age, and computed century, then append each row into .dashboard tbody as required. The age and century are calculated correctly with person.died - person.born and Math.ceil(person.died / 100), so the resulting table should display the expected data without runtime issues. From the perspective of functionality and task requirements, there are no critical blockers that would prevent task completion.
For minor improvements, you could move the genderConvert function above its first use to improve readability, and remove console.log(people) to keep the console clean for production or demo use. It would also be good practice to mention in your PR description which npm run test commands you executed and confirm they passed, even though this isn’t a functional blocker here. Overall, this is a solid implementation that meets the task’s goals—well done.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
DEMO LINK