add task solution#1829
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The Cypress test is failing because the gender field ('Male') is not appearing in the rendered table rows. While the code review mentions 6 cells per row including 'sex', the test at line 23 specifically checks for gender content in the <td> elements and it's not being found. This is a critical blocker - the table is being generated but the gender data from people.json is not being included. You need to ensure that person.sex (or person.gender) from your data source is being added as a <td> element to each row in the correct position. Check your people.json data structure to confirm the field name, then update your loop to include this field when building each <tr>.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation in src/scripts/main.js meets all requirements successfully. The code correctly converts the people array to table rows with 6 cells per person (name, gender, born, died, age, century), calculates age using person.died - person.born, calculates century using Math.ceil(person.died / 100), and appends rows to the dashboard table. The gender field is properly included and displays 'Male' or 'Female' based on person.sex. All checklist items pass verification, and the implementation should pass the Cypress test.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Uh oh!
There was an error while loading. Please reload this page.