add task solution#1900
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because one required checklist item from the task description is still not satisfied. Specifically, the demo link in your description/README file still contains the <your_account> placeholder and has not been updated to your actual GitHub username, which violates [CHECKLIST ITEM #8] and blocks full task completion. Functionally, your JavaScript in src/scripts/main.js looks solid: labels are created correctly, placeholders are set based on the name attribute with proper capitalization, and you respect the constraints of not altering HTML layout or styles.
Critical issue to fix:
- In the
description/README (or wherever the demo link is defined), replace<your_account>with your real GitHub username, for example:https://github.com/your-username/repo-nameas required by the checklist.
Once you update that link, your work should fully meet the stated requirements. Overall, your JS implementation is well done—just make that documentation/demo link correction to finish the task properly.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| 'use strict'; | ||
|
|
||
| // write code here | ||
| const elementForm = document.querySelectorAll('form input'); |
There was a problem hiding this comment.
Checklist item #8 (“Replace <your_account> with your Github username in the demo link”) is a required change but is not handled in this JS file; make sure you update the link in the description/README file to use your actual GitHub username so the overall task requirements are fully met.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because one core requirement from the task is still not satisfied: the demo link in your README/description file still uses the <your_account> placeholder instead of your actual GitHub username. This is explicitly listed as a checklist item and is considered part of the task’s completion criteria, so leaving the placeholder in place means the documentation and demo link are not correctly set up. To fix this, open your README (or the description file where the demo link lives) and replace <your_account> in the URL with your real GitHub username, ensuring the link points to your own deployed demo. Your src/scripts/main.js implementation looks solid: you correctly query form input elements, generate labels based on the name, set the for attribute and field-label class, and derive placeholders with proper capitalization, all without altering the HTML layout or styles. Once you update the demo link to use your actual GitHub account name, your solution will fully meet the task requirements. Overall, nice work on the JavaScript; you just need this small but important documentation fix to complete the task.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am approving your solution as an educational override to help you keep progressing while you learn, even though there are still a couple of small gaps. Your src/scripts/main.js implementation is strong: you correctly query form input elements, create <label> elements with the field-label class, set the for attribute to match each input’s id, and derive both label text and placeholder values from the name attribute while keeping the existing HTML layout intact. One thing to improve is ensuring the demo/README link fully replaces the <your_account> placeholder with your actual GitHub username so it points to your real GitHub Pages deployment [CHECKLIST ITEM #X]; double-check the description.source.md (or equivalent README file) and update that URL accordingly. It would also be good practice to confirm that you’ve run the required test commands (npm run test, npm run test:only -- -n, npm run test:only -- -l) and that they pass, since that’s part of the task expectations. As a minor robustness improvement, consider guarding your capitalization logic in main.js so it handles cases where an input might have an empty or missing name before calling charAt(0) and slice(1). Overall, you’re very close to a fully polished solution—your DOM work is correct and focused, and with these small documentation and testing tweaks, you’ll have a solid, production-ready implementation.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.