task was solved#1675
Open
ihor-soloviov wants to merge 1 commit into
Open
Conversation
Avichez
approved these changes
Jan 10, 2023
Avichez
left a comment
Avichez
left a comment
There was a problem hiding this comment.
Good solution 👍
But there is something that still needs and could be fixed, checklist 2 for sure 🙂
| let counter = 0; | ||
|
|
||
| return (numberOne) => { | ||
| const result = (numbertwo) => { |
There was a problem hiding this comment.
According to cheklist 2, it will be better to make a direct return of the function.
Suggested change
| const result = (numbertwo) => { | |
| return (numbertwo) => { |
|
|
||
| return (numberOne) => { | ||
| const result = (numbertwo) => { | ||
| const sum = numberOne + numbertwo; |
There was a problem hiding this comment.
Just to simplify, you can directly return the result of this expression.
Suggested change
| const sum = numberOne + numbertwo; | |
| return numberOne + numbertwo; |
Comment on lines
+15
to
+16
| if (counter > 3) { | ||
| return counter % 2 === 0 |
There was a problem hiding this comment.
If following the comment above, here will be better to move the expression counter % 2 === 0 to if statement.
Suggested change
| if (counter > 3) { | |
| return counter % 2 === 0 | |
| if (counter > 3 && counter % 2 === 0) { | |
| return 'Bzzz... Error!'; |
Author
There was a problem hiding this comment.
I had no thinking that it's possible. Now it's fixed.
ihor-soloviov
requested review from
Avichez and
alexandra-protyanova
and removed request for
Avichez
alexandra-protyanova
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.