Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm start & sleep 5 && npm test
- name: Upload tests report(cypress mochaawesome merged HTML report)
if: ${{ always() }}
uses: actions/upload-artifact@v2
with:
name: report
path: reports
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Create 2 promises `promise1` and `promise2`.

## Instructions
1. Replace `<your_account>` with your Github username in the link
- [DEMO LINK](https://<your_account>.github.io/js_promise_basic_DOM/)
- [DEMO LINK](https://m-berezovskyy.github.io/js_promise_basic_DOM/)
2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/)
- Run `npm run test` command to test your code;
- Run `npm run test:only -- -n` to run fast test ignoring linter;
Expand Down
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,12 @@
"postinstall": "npm run update",
"test": "npm run lint && npm run test:only"
},
"dependencies": {},
"devDependencies": {
"@linthtml/linthtml": "^0.9.6",
"@mate-academy/eslint-config": "latest",
"@mate-academy/jest-mochawesome-reporter": "^1.0.0",
"@mate-academy/linthtml-config": "latest",
"@mate-academy/scripts": "^1.8.5",
"@mate-academy/scripts": "^2.1.3",
"@mate-academy/stylelint-config": "latest",
"@parcel/transformer-sass": "^2.12.0",
"cypress": "^13.13.0",
Expand Down
46 changes: 45 additions & 1 deletion src/scripts/main.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,47 @@
'use strict';

// write your code here
const logo = document.querySelector('.logo');

const promise1 = new Promise((resolve, reject) => {
logo.addEventListener('click', () => {
resolve();
});
});

promise1.then(() => {
const messageDiv = document.createElement('div');

messageDiv.classList.add('message');
messageDiv.textContent = 'Promise was resolved!';
document.body.append(messageDiv);
});
Comment on lines +11 to +17

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires both success and error handlers for each promise. promise1 currently has only a success handler; you should also add a catch (or second argument to then) that appends the error <div class="message error-message">Promise was rejected!</div> to the body.


promise1.catch(() => {
const errorDiv = document.createElement('div');

errorDiv.classList.add('message', 'error-message');
errorDiv.textContent = 'Promise was rejected!';
document.body.append(errorDiv);
});

const promise2 = new Promise((resolve, reject) => {
setTimeout(() => {
reject(new Error('Timeout!'));
}, 3000);
});

promise2.then(() => {
const messageDiv = document.createElement('div');

messageDiv.classList.add('message');
messageDiv.textContent = 'Promise was resolved!';
document.body.append(messageDiv);
});

promise2.catch(() => {
const errorDiv = document.createElement('div');

errorDiv.classList.add('message', 'error-message');
errorDiv.textContent = 'Promise was rejected!';
document.body.append(errorDiv);
});
Comment on lines +27 to +47

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, promise2 only has an error handler. The requirements say to add success handlers for both promises, so you should also attach a then to promise2 that appends the success <div class="message">Promise was resolved!</div> to the body.

Loading