add task solution#1551
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved because the core functional requirements are correctly implemented in src/scripts/main.js. You correctly create two promises, resolve the first on .logo click, reject the second after 3 seconds, and append the appropriate success and error <div> elements with the required classes and texts. The success and error handlers are wired properly, so there are no critical blockers to the main behavior.
The remaining points are more about project hygiene than broken functionality: make sure you’ve updated the demo link in the README/description with your actual GitHub username [CHECKLIST ITEM #1], and confirm you’ve run the required test commands (npm run test, npm run test:only -- -n, npm run test:only -- -l) [CHECKLIST ITEM #2]. As a minor improvement (not required for approval), you could add a meaningful success branch for promise2 and a .catch for promise1 to make the code more robust and explicit. Overall, you’ve met the task’s functional expectations well—nice work on handling the promises and DOM updates cleanly.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
No description provided.