Skip to content

add task solution#1551

Open
illyaSmyk wants to merge 1 commit into
mate-academy:masterfrom
illyaSmyk:develop
Open

add task solution#1551
illyaSmyk wants to merge 1 commit into
mate-academy:masterfrom
illyaSmyk:develop

Conversation

@illyaSmyk

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved because the core functional requirements are correctly implemented in src/scripts/main.js. You correctly create two promises, resolve the first on .logo click, reject the second after 3 seconds, and append the appropriate success and error <div> elements with the required classes and texts. The success and error handlers are wired properly, so there are no critical blockers to the main behavior.

The remaining points are more about project hygiene than broken functionality: make sure you’ve updated the demo link in the README/description with your actual GitHub username [CHECKLIST ITEM #1], and confirm you’ve run the required test commands (npm run test, npm run test:only -- -n, npm run test:only -- -l) [CHECKLIST ITEM #2]. As a minor improvement (not required for approval), you could add a meaningful success branch for promise2 and a .catch for promise1 to make the code more robust and explicit. Overall, you’ve met the task’s functional expectations well—nice work on handling the promises and DOM updates cleanly.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants