Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm start & sleep 5 && npm test
- name: Upload tests report(cypress mochaawesome merged HTML report)
if: ${{ always() }}
uses: actions/upload-artifact@v2
with:
name: report
path: reports
12 changes: 7 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
# First promises

Create 2 promises `promise1` and `promise2`.

- `promise1` should be resolved on a `click` on `.logo`.
- `promise2` promise should be rejected in 3 seconds.
- add success and error handlers for both promises
- success handler should append a `<div class="message">` with the text `Promise was resolved!` to the body
- error handler should append a `<div class="message error-message">` with the text `Promise was rejected!` to the body

## Instructions

1. Replace `<your_account>` with your Github username in the link
- [DEMO LINK](https://<your_account>.github.io/js_promise_basic_DOM/)
- [DEMO LINK](https://yana-longstocking.github.io/js_promise_basic_DOM/)
2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/)
- Run `npm run test` command to test your code;
- Run `npm run test:only -- -n` to run fast test ignoring linter;
- Run `npm run test:only -- -l` to run fast test with additional info in console ignoring linter.

- Run `npm run test` command to test your code;
- Run `npm run test:only -- -n` to run fast test ignoring linter;
- Run `npm run test:only -- -l` to run fast test with additional info in console ignoring linter.
181 changes: 5 additions & 176 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,12 @@
"postinstall": "npm run update",
"test": "npm run lint && npm run test:only"
},
"dependencies": {},
"devDependencies": {
"@linthtml/linthtml": "^0.9.6",
"@mate-academy/eslint-config": "latest",
"@mate-academy/jest-mochawesome-reporter": "^1.0.0",
"@mate-academy/linthtml-config": "latest",
"@mate-academy/scripts": "^1.8.5",
"@mate-academy/scripts": "^2.1.3",
"@mate-academy/stylelint-config": "latest",
"@parcel/transformer-sass": "^2.12.0",
"cypress": "^13.13.0",
Expand Down
33 changes: 32 additions & 1 deletion src/scripts/main.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,34 @@
'use strict';

// write your code here
const logo = document.querySelector('.logo');

const promise1 = new Promise((resolve, reject) => {
logo.addEventListener('click', () => {
resolve();
});
});

const promise2 = new Promise((resolve, reject) => {
setTimeout(() => {
reject(new Error('The logo was not clicked in time'));
}, 3000);
});

function showMessage(text, isError = false) {
const div = document.createElement('div');

div.classList.add('message');

if (isError) {
div.classList.add('error-message');
}

div.textContent = text;

document.body.appendChild(div);
}

promise1.then(() => showMessage('Promise was resolved!'));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing error handler for promise1. The requirement states 'add success and error handlers for both promises', so promise1 also needs a .catch() handler.

promise1.catch(() => showMessage('Promise was rejected!', true));
promise2.then(() => showMessage('Promise was resolved!'));
promise2.catch(() => showMessage('Promise was rejected!', true));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing success handler for promise2. The requirement states 'add success and error handlers for both promises', so promise2 also needs a .then() handler.

Loading