-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add task solution fix #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add task solution fix #1549
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm start & sleep 5 && npm test | ||
| - name: Upload tests report(cypress mochaawesome merged HTML report) | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: report | ||
| path: reports |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,18 @@ | ||
| # First promises | ||
|
|
||
| Create 2 promises `promise1` and `promise2`. | ||
|
|
||
| - `promise1` should be resolved on a `click` on `.logo`. | ||
| - `promise2` promise should be rejected in 3 seconds. | ||
| - add success and error handlers for both promises | ||
| - success handler should append a `<div class="message">` with the text `Promise was resolved!` to the body | ||
| - error handler should append a `<div class="message error-message">` with the text `Promise was rejected!` to the body | ||
|
|
||
| ## Instructions | ||
|
|
||
| 1. Replace `<your_account>` with your Github username in the link | ||
| - [DEMO LINK](https://<your_account>.github.io/js_promise_basic_DOM/) | ||
| - [DEMO LINK](https://yana-longstocking.github.io/js_promise_basic_DOM/) | ||
| 2. Follow [this instructions](https://mate-academy.github.io/layout_task-guideline/) | ||
| - Run `npm run test` command to test your code; | ||
| - Run `npm run test:only -- -n` to run fast test ignoring linter; | ||
| - Run `npm run test:only -- -l` to run fast test with additional info in console ignoring linter. | ||
|
|
||
| - Run `npm run test` command to test your code; | ||
| - Run `npm run test:only -- -n` to run fast test ignoring linter; | ||
| - Run `npm run test:only -- -l` to run fast test with additional info in console ignoring linter. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,34 @@ | ||
| 'use strict'; | ||
|
|
||
| // write your code here | ||
| const logo = document.querySelector('.logo'); | ||
|
|
||
| const promise1 = new Promise((resolve, reject) => { | ||
| logo.addEventListener('click', () => { | ||
| resolve(); | ||
| }); | ||
| }); | ||
|
|
||
| const promise2 = new Promise((resolve, reject) => { | ||
| setTimeout(() => { | ||
| reject(new Error('The logo was not clicked in time')); | ||
| }, 3000); | ||
| }); | ||
|
|
||
| function showMessage(text, isError = false) { | ||
| const div = document.createElement('div'); | ||
|
|
||
| div.classList.add('message'); | ||
|
|
||
| if (isError) { | ||
| div.classList.add('error-message'); | ||
| } | ||
|
|
||
| div.textContent = text; | ||
|
|
||
| document.body.appendChild(div); | ||
| } | ||
|
|
||
| promise1.then(() => showMessage('Promise was resolved!')); | ||
| promise1.catch(() => showMessage('Promise was rejected!', true)); | ||
| promise2.then(() => showMessage('Promise was resolved!')); | ||
| promise2.catch(() => showMessage('Promise was rejected!', true)); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing success handler for |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing error handler for
promise1. The requirement states 'add success and error handlers for both promises', sopromise1also needs a.catch()handler.